Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-sync vendor assets & Hugo module versions + copyedits to README and CONTRIBUTING #1725

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Nov 10, 2023

@chalin
Copy link
Collaborator Author

chalin commented Nov 10, 2023

@deining - I've tested this using docsy-example, fetching the commit from the branch of this PR, and it works AFAICT.

@chalin chalin force-pushed the chalin-im-vendor-n-vers-2023-11-10 branch from 8ee2dcd to 71d8a52 Compare November 11, 2023 15:10
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo which needs to be corrected.
LGTM otherwise, haven't tested it, though.

assets/_vendor/README.md Show resolved Hide resolved
@chalin chalin merged commit 71d8a52 into main Nov 12, 2023
7 checks passed
@chalin
Copy link
Collaborator Author

chalin commented Nov 12, 2023

Oh dang, tripped on the buttons somehow (or was it GH Desktop?).
Or maybe because I had two branches with the same name in my fork and here ... .
Anyhow, I didn't mean to merge this yet. I'll fix the typo in a followup commit.

@chalin chalin deleted the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:38
@chalin
Copy link
Collaborator Author

chalin commented Nov 12, 2023

Yeah, it wasn't the GH interface that did the merge, because it didn't squash the commits, which I have enabled by default. It must have been the GH desktop. :-(

@chalin
Copy link
Collaborator Author

chalin commented Nov 12, 2023

My typo fix even made it into main!

@chalin
Copy link
Collaborator Author

chalin commented Nov 12, 2023

Ok, I've reverted the commit and will resubmit a PR ... . See:

@chalin chalin restored the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:50
@chalin chalin deleted the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate the updating of vendor assets Ensure that versions of dependencies remain in sync
2 participants