[BSv5] Footer fixes: reset flex-shrink, and more #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-footer-fix-2023-01-25
branch
from
d52f088
to
e96963a
Compare
dseynaev
pushed a commit
to openanalytics/docsy
that referenced
this pull request
Jan 29, 2023
7 tasks
chalin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text-rightbecomestext-endflex-shrinkto the default of 1 in the footer container. Otherwise the margin settings cause the footer container to overflow. I've inquired as to why theflex-shrinkvalue was changed to 0 for all columns:Why flex-shrink 0 for all columns? twbs/bootstrap#37951
Note that icons are a bit smaller, so the footer "links block" will be a bit narrower.