Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Footer: drop flex-shrink tweak + other adjustments #1523

Merged
merged 1 commit into from
May 26, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 26, 2023

Preview: https://deploy-preview-1523--docsydocs.netlify.app


Screenshots

Showing breakpoint mismatch between page content and footer layout.

Before:

Screen Shot 2023-05-26 at 11 13 38

After:

Screen Shot 2023-05-26 at 11 13 08

@chalin chalin requested a review from LisaFC May 26, 2023 15:28
@chalin chalin marked this pull request as draft May 26, 2023 15:29
@chalin chalin force-pushed the chalin-im-foot-adj-2023-05-26 branch from f3226c4 to b006a7d Compare May 26, 2023 15:53
@chalin chalin force-pushed the chalin-im-foot-adj-2023-05-26 branch from b006a7d to 3565e60 Compare May 26, 2023 16:03
@chalin chalin marked this pull request as ready for review May 26, 2023 16:05
Comment on lines +42 to +44
- `$list-inline-padding` is increased in support of footer icons ([#1523]). If
this global adjustment is a problem for your project, let us know and we can
contextualize the adjustment to the footer.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC et al.: note the design decision of making a global parameter adjustment (the simplest change), but asking projects for feedback in case it causes problems for them.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me - I'm sure people will report back if it breaks anything and it doesn't seem to have done so in our site.

@LisaFC
Copy link
Collaborator

LisaFC commented May 26, 2023

Oh yes, that looks much better, thanks Patrice!

@chalin chalin merged commit 4813275 into google:main May 26, 2023
@chalin chalin deleted the chalin-im-foot-adj-2023-05-26 branch May 26, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BSv5] Row/col formatting breaks Docsy components
2 participants