Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-cn support for i18n #712

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Add zh-cn support for i18n #712

merged 1 commit into from
Oct 8, 2021

Conversation

y1hao
Copy link
Contributor

@y1hao y1hao commented Oct 6, 2021

This PR adds a zh-cn.toml file into the i18n folder. The content is exactly the same as zh.toml.

Doing so will allow the users of this theme to use zh-cn as the language code, and still keep the translation.

For example, currently Gin's website use zh-cn and zh-tw for 2 different versions of Chinese languages, neither of them are supported by this theme, so the text from this theme just fall-through to en, causing inconsistency.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2021
@LisaFC
Copy link
Collaborator

LisaFC commented Oct 8, 2021

Thanks!

@LisaFC LisaFC merged commit 1f9823e into google:master Oct 8, 2021
@h1z3y3 h1z3y3 mentioned this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants