Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese lang ID: zhzh-cn #769

Closed
jihoon-seo opened this issue Apr 20, 2022 · 4 comments · Fixed by #869
Closed

Update Chinese lang ID: zhzh-cn #769

jihoon-seo opened this issue Apr 20, 2022 · 4 comments · Fixed by #869
Labels
lang/zh for Chinese maintainers Use this label if PR requires maintainers to take action

Comments

@jihoon-seo
Copy link
Collaborator

Recently, Docsy has renamed language 'zh' to 'zh-cn'.
(Ref: google/docsy#832)

And after updating Docsy used by kubernetes/website repo,
this causes some issues (like this, and so on..).

To resolve this, Qiming Teng, an active English & Chinese approver in kubernetes/website repo, suggested a solution:
update the Chinese language identifier from zh to zh-cn,
causing everything under https//kubernetes.io/zh/* to be moved to https//kubernetes.io/zh-cn/* .

It is likely that we update our Docsy version some time or other, and that we will encounter this issue too.

So I suggest to update the Chinese language identifier from zh to zh-cn in CNCF Glossary project, before dev-zh goes live,
because updating before dev-zh going live will be better than updating after dev-zh going live.
(Which means that Chinese contents will be live in https://glossary.cncf.io/zh-cn/, not https://glossary.cncf.io/zh/.)

How about your thoughts,
Chinese approvers (@hanyuancheung @Jacob953 @Rocksnake @Submarinee) and
maintainers and English approvers (@cjyabraham @CathPag @JasonMorgan @seokho-son @iamNoah1) ? 😊

[Refs]

@jihoon-seo jihoon-seo added maintainers Use this label if PR requires maintainers to take action lang/zh for Chinese labels Apr 20, 2022
@seokho-son
Copy link
Collaborator

Hi @cjyabraham
Do you have a plan to update Docsy theme version ? :)
If we update it, we need to apply the issue raised by @jihoon-seo

@cjyabraham
Copy link
Contributor

I'm not planning it, however, it makes sense to update it if we want to take advantage of any updates and new features. So I think this issue is a good idea to get ahead of the directory change.

@hanyuancheung
Copy link
Collaborator

On behalf of the Chinese team, I agree to change the branch name as suggested!

@Jacob953 Jacob953 moved this from To do to In progress in Chinese Location Progress May 7, 2022
This was referenced May 8, 2022
@jihoon-seo jihoon-seo linked a pull request May 8, 2022 that will close this issue
@jihoon-seo
Copy link
Collaborator Author

Resolved by #869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/zh for Chinese maintainers Use this label if PR requires maintainers to take action
Development

Successfully merging a pull request may close this issue.

4 participants