-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language support to zh #33050
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-io-main-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Docsy has renamed language 'zh' to 'zh-cn'. This is causing a huge problem for the Chinese localization. This PR is a first step to fix this problem. Follow up PRs are needed to fix all the relative links.
/hold |
/hold cancel |
This PR will close #33002. [Preview]
|
Oops. The update looked OK to me but I didn't try following links. We could add a 302 redirect from |
@@ -300,15 +300,15 @@ languageName ="English" | |||
weight = 1 | |||
languagedirection = "ltr" | |||
|
|||
[languages.zh] | |||
[languages.zh-cn] | |||
title = "Kubernetes" | |||
description = "生产级别的容器编排系统" | |||
languageName = "中文 Chinese" | |||
weight = 2 | |||
contentDir = "content/zh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links in the preview of this PR (like here and there) are still pointing /zh/
, and I guess that this is because:
contentDir = "content/zh" | |
contentDir = "content/zh-cn" |
But it might be okay, since the PR #33051 is already covering this.
Links in the preview of the PR #33051 looks fine:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot change it yet. Because we don't have the content/zh-cn
directory yet in this PR.
Yes. Adding a single 302 redirection would be nice. |
/close |
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Docsy has renamed language 'zh' to 'zh-cn'. This is causing a huge problem for the Chinese localization.
This PR is a first step to fix this problem. Follow up PRs are needed to fix all the relative links.