False positive in UnnecessaryDefaultInEnumSwitch triggered by (presumed) compiler bug
#849
Comments
Merged
|
A colleague of mine hit this issue again earlier this week. We were not (yet) successful in tracking down what actually causes the NPE. In PR #1020 the code is updated to no longer log the stacktrace you see above. I'd like to ask that instead/additionally the first suggestion above (the |
Merged
ronshapiro
pushed a commit
that referenced
this issue
May 8, 2018
"Fixes" #849 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195434516
ronshapiro
pushed a commit
that referenced
this issue
May 9, 2018
"Fixes" #849 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=195434516
|
Issue update: In PR #1023 the suggestion to NB: my colleague saw the issue go away by itself when he moved some Immutables interfaces to another package in another Maven module. We won't dig deeper into this, but I suspect the associated classpath change or the involvement of an annotation processor is relevant here. |
|
@cushon your fix in 9f94242 was modified in 02cebcd, such that non- If you think the earlier suggestion to prune certain compiler arguments makes sense I can file a PR with a proposal. (The NPE shown above still reproduces with AdoptOpenJDK 11.0.5+10. With a debugger I can see that it happens when doclint analyzes the class Javadoc of an Immutables-generated type derived from an interface nested in an abstract class; for this type |
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jan 12, 2020
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Something like this: PicnicSupermarket/error-prone@ee33249, optionally optimized by placing the flags to be filtered in an |
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 30, 2020
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jan 16, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jan 16, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
|
An updated version of the above commit, compatible with Error Prone 2.5.1, can be found at PicnicSupermarket/error-prone@10bd828. |
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 2, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 15, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 15, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jul 23, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 4, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 20, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Nov 13, 2021
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
|
An updated version of the above commit, compatible with Error Prone 2.10.0, can be found at PicnicSupermarket/error-prone@0d7427a. |
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jan 26, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 13, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 13, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 15, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 16, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jun 5, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 4, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 12, 2022
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 10, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jun 17, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jun 17, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 2, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 5, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Sep 22, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 19, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Dec 21, 2023
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jan 3, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Feb 16, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Mar 11, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Mar 12, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Apr 26, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 1, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
May 31, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jul 17, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jul 17, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Jul 19, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 10, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 29, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 29, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 31, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 31, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Aug 31, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Sep 11, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 1, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 19, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 26, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Oct 26, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Stephan202
added a commit
to PicnicSupermarket/error-prone
that referenced
this issue
Nov 19, 2024
Under certain circumstances this avoids triggering a compiler bug. It is also expected to speed up the trial compilation somewhat. The implicit assumption here is that it is okay to suggest a fix which introduces another warning. (This may not be so in general, but the introduced warning may be less severe or may be resolved manually.) See google#849.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I cannot provide a small reproduction case yet, but let me describe the situation.
Some code triggers the following warning:
In actuality this code is covered by case 3: the
defaultclause cannot be removed without breaking the code.Above this warning the following stacktrace is logged:
This stacktrace is logged at SuggestedFixes.java:662. When I drop the
-Xdoclint:referenceflag from our build configuration no stacktrace is logged and the false positive goes away.I have two questions for the Error Prone team:
return falsestatement afterSuggestedFixes.java:662, just to be safe?#compilesWithFixis very expensive, so perhaps it's worthwhile to drop-Xdoclintand certain other flags. (Such as-verbose; nobody's reading the output anyway.)The text was updated successfully, but these errors were encountered: