Moe Sync #1258
Merged
Moe Sync #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=236679921
RELNOTES: `Matchers.instanceMethod` is no longer supported; prefer `MethodMatchers.instanceMethod()` RELNOTES: `Matchers.isDescendantOfMethod(className, methodName)` is no longer supported; prefer `MethodMatchers.instanceMethod().onDescendantOf(className).named(methodName)` ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=236682057
… is often done to allow the garbage collector to collect an expensive object. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=236814402
Sadly this didn't turn up the actual bug, but having coverage for these seems good. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=236825580
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=237112378
…e argument type of Comparable can be cast to the owning class type ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=237167544
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=237204717
|
This is just a partial sync, since we've been seeing intermittent MOE issues internally. Those seem to be resolved around ~late March, so I recommend that we consider merging this even if the tests are broken, that way we can hopefully make continual progress to getting internal -> external fully synced. Even if tests are broken, fixing+resyncing may be quite difficult all as one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Add another Dagger 1 codegen case to RefersToDaggerCodegen
RELNOTES: n/a
1fcb40e
Remove some deprecated matchers
RELNOTES:
Matchers.instanceMethodis no longer supported; preferMethodMatchers.instanceMethod()RELNOTES:
Matchers.isDescendantOfMethod(className, methodName)is no longer supported; preferMethodMatchers.instanceMethod().onDescendantOf(className).named(methodName)f493911
RELNOTES: UnusedVariable: don't warn when nulling out variables. This is often done to allow the garbage collector to collect an expensive object.
e263f35
RELNOTES: Tests for external issue #1234.
Sadly this didn't turn up the actual bug, but having coverage for these seems good.
97767bb
Preserve non-constant messages in fail() in exception tests RELNOTES: N/A
b2730be
RELNOTES: In ComparableType, require an exact match, not just that the argument type of Comparable can be cast to the owning class type
38c65b4
RELNOTES: Remove the exemption for GoogleLoggers from UnusedVariable.
784101c