Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moe Sync #1258

Merged
merged 7 commits into from
Apr 12, 2019
Merged

Moe Sync #1258

merged 7 commits into from
Apr 12, 2019

Commits on Apr 12, 2019

  1. Add another Dagger 1 codegen case to RefersToDaggerCodegen 

    RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=236679921
    @ronshapiro
    ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    1fcb40e View commit details
    Browse the repository at this point in the history

  2. Remove some deprecated matchers 

    RELNOTES: `Matchers.instanceMethod` is no longer supported; prefer `MethodMatchers.instanceMethod()`
RELNOTES: `Matchers.isDescendantOfMethod(className, methodName)` is no longer supported; prefer `MethodMatchers.instanceMethod().onDescendantOf(className).named(methodName)`

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=236682057
    @cushon @ronshapiro
    cushon authored and ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f493911 View commit details
    Browse the repository at this point in the history

  3. RELNOTES: UnusedVariable: don't warn when nulling out variables. This… 

    … is often done to allow the garbage collector to collect an expensive object.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=236814402
    @graememorgan @ronshapiro
    graememorgan authored and ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    e263f35 View commit details
    Browse the repository at this point in the history

  4. RELNOTES: Tests for external issue #1234. 

    Sadly this didn't turn up the actual bug, but having coverage for these seems good.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=236825580
    @graememorgan @ronshapiro
    graememorgan authored and ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    97767bb View commit details
    Browse the repository at this point in the history

  5. Preserve non-constant messages in fail() in exception tests 

    RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237112378
    @cushon @ronshapiro
    cushon authored and ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    b2730be View commit details
    Browse the repository at this point in the history

  6. RELNOTES: In ComparableType, require an exact match, not just that th… 

    …e argument type of Comparable can be cast to the owning class type

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237167544
    @cushon @ronshapiro
    cushon authored and ronshapiro committed Apr 12, 2019
    1 Configuration menu
    Copy the full SHA
    38c65b4 View commit details
    Browse the repository at this point in the history

  7. RELNOTES: Remove the exemption for GoogleLoggers from UnusedVariable. 

    -------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237204717
    @graememorgan @ronshapiro
    graememorgan authored and ronshapiro committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    784101c View commit details
    Browse the repository at this point in the history