Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add support for ConcurrentHashMap in AbstractAsKeyOfSetOrMap #1329

Closed

Conversation

blemale
Copy link
Contributor

@blemale blemale commented Aug 7, 2019

Add support for ConcurrentHashMap in AbstractAsKeyOfSetOrMap, thus the error patterns ArrayAsKeyOfSetOrMap and ProtosAsKeyOfSetOrMap are available for ConcurrentHashMap.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@blemale
Copy link
Contributor Author

blemale commented Aug 7, 2019

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 7, 2019
@blemale blemale force-pushed the Add_support_for_ConcurrentHashMap branch from 950794f to 397829c Compare August 7, 2019 14:56
@blemale
Copy link
Contributor Author

blemale commented Aug 12, 2019

@nglorioso could you take a look at this small PR?

netdpb pushed a commit that referenced this pull request Aug 16, 2019
AbstractAsKeyOfSetOrMap

Fixes #1329

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=263039480
@netdpb netdpb mentioned this pull request Aug 16, 2019
cpovirk pushed a commit that referenced this pull request Aug 20, 2019
AbstractAsKeyOfSetOrMap

Fixes #1329

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=263039480
@cpovirk cpovirk mentioned this pull request Aug 20, 2019
cpovirk pushed a commit that referenced this pull request Aug 20, 2019
AbstractAsKeyOfSetOrMap

Fixes #1329

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=263039480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants