Moe Sync #1331
Moe Sync #1331
Conversation
AbstractAsKeyOfSetOrMap Fixes #1329 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263039480
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263085018
Perhaps this is more clear? ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263117912
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263164929
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263392740
The focal point here was SuppresionInfo.withExtendedSuppressions. This method is called for every matcher at every AST node, so any expense is greatly magnified. This commit caches the Name objects ahead of time instead of looking them up each time. Additionally, ASTHelpers has gained a method for testing a set of annotations in one go, so clients don't have to call hasAnnotation many times. The net result is that the method is around twice as fast as it was before, saving us 1.1% of total javac time. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263396675
This was a smaller performance win than I expected, only 0.18% of javac time, but still better than the status quo. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263396751
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263486443
as well as Sets.{union,disjoint}.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=263488994
…tive types. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=263523647
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@blemale Can you please follow the instructions in #1331 (comment): leave a comment here that contains only |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks. Merged in #1332 instead. |
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
[core] Add support for ConcurrentHashMap in AbstractAsKeyOfSetOrMap
Fixes #1329
2453670
LiteProtoToString: provide a separate description and fix for enums.
24b34be
s/override/overriding method/
Perhaps this is more clear?
c5e4b17
Support lambdas for @CompileTimeConstant
d2b9aba
Update checker to reflect current API name
fbaa109
Improve performance of annotation scanning
The focal point here was SuppresionInfo.withExtendedSuppressions. This
method is called for every matcher at every AST node, so any expense
is greatly magnified. This commit caches the Name objects ahead of
time instead of looking them up each time. Additionally, ASTHelpers
has gained a method for testing a set of annotations in one go, so
clients don't have to call hasAnnotation many times.
The net result is that the method is around twice as fast as it was
before, saving us 1.1% of total javac time.
e7e61b3
Cache the Name used in Matchers.hasAnnotation
This was a smaller performance win than I expected, only 0.18% of
javac time, but still better than the status quo.
6c2106a
Improve next/prev/last statement matches
b3953f5
Check for misuses of Collections.disjoint in CollectionIncompatibleType
as well as Sets.{union,disjoint}.
e19c4dd
Add bugpattern to discourage AtomicReference#compareAndSet with primitive types.
c05e3d3