UnnecessaryCheckNotNull correctly qualifies Preconditions #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously other imports or nested classes named Preconditions caused the suggested fix to fail.
Merged
netdpb
pushed a commit
that referenced
this pull request
Jan 7, 2020
…ition we want to use. And encourage static importing it; that is the Java practices guidance after all. This introduces a SuggestedFixes helper to get a name to refer to methods that we want to try to static import, but fall back to qualifying if necessary. This addresses PR #1433, though not in the same way. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288470257
netdpb
pushed a commit
that referenced
this pull request
Jan 7, 2020
…ition we want to use. And encourage static importing it; that is the Java practices guidance after all. This introduces a SuggestedFixes helper to get a name to refer to methods that we want to try to static import, but fall back to qualifying if necessary. This addresses PR #1433, though not in the same way. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288470257
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Feb 19, 2020
…ition we want to use. And encourage static importing it; that is the Java practices guidance after all. This introduces a SuggestedFixes helper to get a name to refer to methods that we want to try to static import, but fall back to qualifying if necessary. This addresses PR google#1433, though not in the same way. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288470257
|
Thanks for the report! This was resolved by b920acf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously other imports or nested classes named Preconditions
caused the suggested fix to fail.