MOE Sync 2020-01-07 #1466
MOE Sync 2020-01-07 #1466
Conversation
…verifyNotNull/requireNonNull as boxed usages. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288307159
…tions of AutoCloseable.close ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288347399
Fixes #1458 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288366205
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288397819
follow-up to 96b1759 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288408806
…cate positions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288464145
…ition we want to use. And encourage static importing it; that is the Java practices guidance after all. This introduces a SuggestedFixes helper to get a name to refer to methods that we want to try to static import, but fall back to qualifying if necessary. This addresses PR #1433, though not in the same way. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288470257
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
UnnecessaryBoxedVariable: don't consider invocations of checkNotNull/verifyNotNull/requireNonNull as boxed usages.
d6fccbd
InterruptedExceptionSwallowed: Handle classes that inherit implementations of AutoCloseable.close
8d74d24
Bump maven-compiler-plugin version to 3.8.1.
Fixes #1458
fd3c60a
Various docs changes.
29789d6
MissingSuperCall: Ignore super calls inside lambdas
follow-up to 96b1759
1850c4a
AlmostJavadoc: skip desugared enum subclasses, as these lead to duplicate positions.
17abebd
UnnecessaryCheckNotNull: be more careful about qualifying the precondition we want to use.
And encourage static importing it; that is the Java practices guidance after all.
This introduces a SuggestedFixes helper to get a name to refer to methods that we want to try to static import, but fall back to qualifying if necessary.
This addresses PR #1433, though not in the same way.
b920acf