Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOE Sync 2020-02-10 #1511

Merged
merged 1 commit into from
Feb 11, 2020
Merged

MOE Sync 2020-02-10 #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/java/com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public final class PreferJavaTimeOverload extends BugChecker

private static final Matcher<ExpressionTree> IGNORED_APIS =
anyOf(
staticMethod().onClass("org.jooq.impl.DSL").named("inline"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, any specific reason you didn't compare return types taking generics into account? (i.e. in this specific case, treating Param<Long> and Param<Instant> as different return types, such that DSL.inline(long) and DSL.inline(Instant) would no longer be considered overloads of each other)

// any static method under org.assertj.*
staticMethod()
.onClass((type, state) -> type.toString().startsWith("org.assertj."))
Expand Down