MOE Sync 2020-02-10 #1511
Merged
MOE Sync 2020-02-10 #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1504 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=294228509
tbroyer
reviewed
Feb 11, 2020
| @@ -112,6 +112,7 @@ | |||
|
|
|||
| private static final Matcher<ExpressionTree> IGNORED_APIS = | |||
| anyOf( | |||
| staticMethod().onClass("org.jooq.impl.DSL").named("inline"), | |||
There was a problem hiding this comment.
Out of curiosity, any specific reason you didn't compare return types taking generics into account? (i.e. in this specific case, treating Param<Long> and Param<Instant> as different return types, such that DSL.inline(long) and DSL.inline(Instant) would no longer be considered overloads of each other)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Ignore DSL.inline() in PreferJavaTimeOverload checker.
Fixes #1504
2b1d640