Moe Sync #1547
Moe Sync #1547
Conversation
it is disabled by default, and has bugs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302219979
See #1106 - field removed in JDK12 as per Fixes #1107 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302397069
…ription's constructor. To fulfil a TODO, and allow tidying up the API. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302410595
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302422163
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302424445
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Setting CLA: yes from CLA agreement in #1107 |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Turn down ReturnMissingNullable
it is disabled by default, and has bugs.
e5dfb88
Finally: Replace `.label` by `.getLabel()`
See #1106 - field removed in JDK12 as per
Fixes #1107
f838f78
Obtain Descriptions for testing via BugCheckers, rather than via Description's constructor.
To fulfil a TODO, and allow tidying up the API.
1477732
Fix two typos (for the price of one)
6744ce2
Enable Javadoc-related checkers by default
363cca1