-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally: Replace .label
by .getLabel()
#1107
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon04
pushed a commit
to JOSM/josm
that referenced
this pull request
Sep 4, 2018
…r_prone, patched for Java 12 compatibility See google/error-prone#1107 See google/error-prone@3f2ca43#commitcomment-30382503 git-svn-id: https://josm.openstreetmap.de/svn/trunk@14222 0c6e7542-c601-0410-84e7-c038aed88b3b
This was referenced Sep 4, 2018
floscher
pushed a commit
to floscher/josm
that referenced
this pull request
Sep 5, 2018
…r_prone, patched for Java 12 compatibility See google/error-prone#1107 See google/error-prone@3f2ca43#commitcomment-30382503 git-svn-id: https://josm.openstreetmap.de/svn/trunk@14222 0c6e7542-c601-0410-84e7-c038aed88b3b
Closed
I also encountered this exception in https://gitlab.com/JOSM/Mapillary/-/jobs/107783724 |
@floscher you can use JOSM patched version of error_prone |
@cushon |
@cushon - Looking forward for this change :) |
See google#1106 - field removed in JDK12 as per http://hg.openjdk.java.net/jdk/jdk/rev/de411d537aae#l26.131
johsin18
pushed a commit
to johsin18/josm
that referenced
this pull request
Mar 1, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
@graememorgan please review |
bgalek
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nick-someone
pushed a commit
that referenced
this pull request
Mar 23, 2020
See #1106 - field removed in JDK12 as per Fixes #1107 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302397069
Merged
nick-someone
pushed a commit
that referenced
this pull request
Mar 23, 2020
See #1106 - field removed in JDK12 as per Fixes #1107 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=302397069
simon04
pushed a commit
to JOSM/josm
that referenced
this pull request
Mar 25, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
floscher
pushed a commit
to floscher/josm
that referenced
this pull request
Oct 28, 2020
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13): - google/error-prone#1107 - google/error-prone#1110 - google/error-prone#1111 - google/error-prone#1398 - google/error-prone#1439 git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1106 - field removed in JDK12 as per
http://hg.openjdk.java.net/jdk/jdk/rev/de411d537aae#l26.131