Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GuardedByUtils: return empty set instead of null #1110

Closed
wants to merge 1 commit into from
Closed

GuardedByUtils: return empty set instead of null #1110

wants to merge 1 commit into from

Conversation

don-vip
Copy link
Contributor

@don-vip don-vip commented Sep 5, 2018

See #1106 (comment)

This fixes an NPE seen with JDK12 (when #1107 is merged):

[javac]     public final WaySegment getNearestWaySegment(Point p, Predicate<OsmPrimitive> predicate,
    [javac]                             ^
    [javac]      Please report this at https://github.com/google/error-prone/issues/new and include the following:
    [javac]   
    [javac]      error-prone version: 2.3.2-SNAPSHOT
    [javac]      BugPattern: GuardedBy
    [javac]      Stack Trace:
    [javac]      java.lang.NullPointerException
    [javac]   	at com.google.errorprone.bugpatterns.threadsafety.HeldLockAnalyzer$LockScanner.checkMatch(HeldLockAnalyzer.java:227)
    [javac]   	at com.google.errorprone.bugpatterns.threadsafety.HeldLockAnalyzer$LockScanner.visitIdentifier(HeldLockAnalyzer.java:196)
    [javac]   	at com.google.errorprone.bugpatterns.threadsafety.HeldLockAnalyzer$LockScanner.visitIdentifier(HeldLockAnalyzer.java:116)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCIdent.accept(JCTree.java:2324)

simon04 pushed a commit to JOSM/josm that referenced this pull request Sep 5, 2018
@don-vip
see #16498 - fix NPE in error_prone
78ca690 
See google/error-prone#1110
See google/error-prone#1106 (comment)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14225 0c6e7542-c601-0410-84e7-c038aed88b3b
floscher pushed a commit to floscher/josm that referenced this pull request Sep 5, 2018
@don-vip
see #16498 - fix NPE in error_prone
7abb643 
See google/error-prone#1110
See google/error-prone#1106 (comment)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14225 0c6e7542-c601-0410-84e7-c038aed88b3b
This was referenced Sep 5, 2018
Closed
Closed
@cushon
Copy link
Collaborator

cushon commented Sep 6, 2018

Can you add a unit test? It is it covered by existing tests when running in JDK 12?

johsin18 pushed a commit to johsin18/josm that referenced this pull request Mar 1, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
bf3a6f0 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
simon04 pushed a commit to JOSM/josm that referenced this pull request Mar 25, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
6ef5433 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
TimvdLippe added a commit to TimvdLippe/error-prone that referenced this pull request Apr 15, 2020
@TimvdLippe
Update build matrix for Java 12
47ae679 
This allows us to check that ErrorProne works on Java 12. It is part of
issue google#1106 to make ErrorProne work on newer versions of Java.

It will allow us to verify that google#1110 indeed fixes the problem with Java
12.
@TimvdLippe TimvdLippe mentioned this pull request Apr 15, 2020
Closed
@cushon
Copy link
Collaborator

cushon commented May 14, 2020

I have tests passing on JDK 12 and am still not observing the problem this solves, do you have a repro?

kluever pushed a commit that referenced this pull request May 17, 2020
@don-vip @kluever
GuardedByUtils: return empty set instead of null
8f05406 
Fixes #1110

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311825676
@kluever kluever mentioned this pull request May 17, 2020
Merged
kluever pushed a commit that referenced this pull request May 17, 2020
@don-vip @kluever
GuardedByUtils: return empty set instead of null
1341c4e 
Fixes #1110

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311825676
@don-vip don-vip deleted the jdk12_pr2 branch June 1, 2020 16:58
floscher pushed a commit to floscher/josm that referenced this pull request Oct 28, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
f8fc0c8 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@don-vip @cushon @googlebot