Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanBeStatic: Fix NPE #1111

Closed
wants to merge 1 commit into from
Closed

CanBeStatic: Fix NPE #1111

wants to merge 1 commit into from

Conversation

don-vip
Copy link
Contributor

@don-vip don-vip commented Sep 5, 2018

See #1106 (comment)

Solves NPE (after #1107 and #1110 are merged) with Java 12:

[javac]      error-prone version: 2.3.2-SNAPSHOT
    [javac]      BugPattern: ClassCanBeStatic
    [javac]      Stack Trace:
    [javac]      java.lang.NullPointerException
    [javac]   	at com.google.errorprone.bugpatterns.CanBeStaticAnalyzer.visitIdent(CanBeStaticAnalyzer.java:60)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCIdent.accept(JCTree.java:2316)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.visitBreak(TreeScanner.java:222)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBreak.accept(JCTree.java:1559)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:57)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.visitBlock(TreeScanner.java:143)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.visitIf(TreeScanner.java:213)
    [javac]   	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCIf.accept(JCTree.java:1486)

simon04 pushed a commit to JOSM/josm that referenced this pull request Sep 5, 2018
@don-vip
see #16498 - fix NPE in error_prone
bea6778 
See google/error-prone#1111
See google/error-prone#1106 (comment)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14226 0c6e7542-c601-0410-84e7-c038aed88b3b
@don-vip don-vip mentioned this pull request Sep 5, 2018
Closed
@cushon
Copy link
Collaborator

cushon commented Sep 6, 2018

Can you add a test?

floscher pushed a commit to floscher/josm that referenced this pull request Sep 6, 2018
@don-vip
see #16498 - fix NPE in error_prone
a41bc95 
See google/error-prone#1111
See google/error-prone#1106 (comment)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14226 0c6e7542-c601-0410-84e7-c038aed88b3b
johsin18 pushed a commit to johsin18/josm that referenced this pull request Mar 1, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
bf3a6f0 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
simon04 pushed a commit to JOSM/josm that referenced this pull request Mar 25, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
6ef5433 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
@kluever kluever mentioned this pull request May 17, 2020
Merged
kluever pushed a commit that referenced this pull request May 17, 2020
@don-vip @kluever
Add a null-check in CanBeStatic
12e2544 
JDK 12 changes the representation of labelled breaks to use an identifier for
the label (instead of just a name), and the identifier doesn't have a symbol.

Fixes #1111

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311832221
kluever pushed a commit that referenced this pull request May 17, 2020
@don-vip @kluever
Add a null-check in CanBeStatic
bc99307 
JDK 12 changes the representation of labelled breaks to use an identifier for
the label (instead of just a name), and the identifier doesn't have a symbol.

Fixes #1111

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311832221
@don-vip don-vip deleted the jdk12_pr3 branch June 1, 2020 16:58
floscher pushed a commit to floscher/josm that referenced this pull request Oct 28, 2020
@don-vip
see #17516 - update to error-prone 2.3.5-SNAPSHOT plus following patc…
f8fc0c8 
…hes for Java 13 compatibility (https://github.com/don-vip/error-prone/commits/jdk13):

- google/error-prone#1107
- google/error-prone#1110
- google/error-prone#1111
- google/error-prone#1398
- google/error-prone#1439

git-svn-id: https://josm.openstreetmap.de/svn/trunk@15963 0c6e7542-c601-0410-84e7-c038aed88b3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@don-vip @cushon @googlebot