fix: apply applyCrossFade to correct entity #7665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannojg
added a commit
to margelo/react-native-filament
that referenced
this pull request
Mar 13, 2024
pixelflinger
approved these changes
Mar 13, 2024
poweifeng
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago an API was added that supports creating multiple instances from one asset.
Due to that that instance used in an Animator might not be
asset->mRoot, but another instance. To account for that.The
applyAnimationfunction handled this correctly, however theapplyCrossFadewasn't updated and was still usingasset->mRoot.This PR adds a conditional to either use the provided instance in
applyCrossFadeor to use the asset's root entity.