fix: Fix #49 where applyCrossFade not working for copied animators #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrousavy
reviewed
Mar 13, 2024
| if (pengu.state === 'loaded') { | ||
| pengu.animator.applyAnimation(0, passedSeconds) | ||
| pengu.animator.updateBoneMatrices() | ||
| engine.getCamera().lookAt(cameraPosition, cameraTarget, cameraUp) |
There was a problem hiding this comment.
If getCamera() is used like this all the time, maybe it makes sense to make it a readonly prop? engine.camera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that in the filament code the
applyCrossFadewasn't updated when they added the API to create multiple instances from one asset.This PR updates the patch to add support for that.
Additionally a PR at filament has been added to fix it upstream: