Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getFullyQualifiedName has underscores in typescript/javascript #7564

Closed
jkuszmaul opened this issue Oct 4, 2022 · 0 comments · Fixed by #7730
Closed

getFullyQualifiedName has underscores in typescript/javascript #7564

jkuszmaul opened this issue Oct 4, 2022 · 0 comments · Fixed by #7730

Comments

@jkuszmaul
Copy link
Contributor

It appears that #7451 changed getFullyQualifiedName to return underscores instead of . as the separator between namespace levels for typescript/javascript code. This seems wrong.

I can probably take care of this at some point, but may not get to it all that quickly.
jkuszmaul added a commit to jkuszmaul/flatbuffers that referenced this issue Dec 22, 2022
@jkuszmaul
[TS] Fix getFullyQualifiedName codegen for typescript
4268ac4 
 google#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes google#7564.
@jkuszmaul jkuszmaul mentioned this issue Dec 22, 2022
Merged
dbaileychess added a commit that referenced this issue Dec 22, 2022
@jkuszmaul @dbaileychess
[TS] Fix getFullyQualifiedName codegen for typescript (#7730)
e43a80c 
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this issue Dec 25, 2022
@jkuszmaul @dbaileychess
[TS] Fix getFullyQualifiedName codegen for typescript (google#7730)
943c5c9 
google#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes google#7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TS] Fix getFullyQualifiedName codegen for typescript jkuszmaul/flatbuffers
1 participant
@jkuszmaul