[TS] Fix getFullyQualifiedName codegen for typescript #7730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google#7451 caused getFullyQualifiedName to return a name with underscores, not periods. Because the fully qualified name is a property of FlatBuffers, not the language being codegen'd for, it should use periods. Fixes google#7564.
github-actions
bot
added
c++
codegen
dbaileychess
approved these changes
Dec 22, 2022
|
Thanks! |
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Dec 25, 2022
google#7451 caused getFullyQualifiedName to return a name with underscores, not periods. Because the fully qualified name is a property of FlatBuffers, not the language being codegen'd for, it should use periods. Fixes google#7564. Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of FlatBuffers, not the language being codegen'd for, it should use periods.
Fixes #7564.