added default params rng to .apply #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Feb 15, 2024
| @@ -1074,9 +1074,19 @@ def apply( | |||
| def wrapper( | |||
| variables: VariableDict, | |||
| *args, | |||
| rngs: Optional[RNGSequences] = None, | |||
| rngs: Optional[Union[PRNGKey, RNGSequences]] = None, | |||
There was a problem hiding this comment.
Suggested change
| rngs: Optional[Union[PRNGKey, RNGSequences]] = None, | |
| rngs: PRNGKey | RNGSequences | None = None, |
There was a problem hiding this comment.
won't this fail Github CI for python 3.9?
There was a problem hiding this comment.
our minimum Python version is still 3.9.
cgarciae
reviewed
Feb 16, 2024
| **kwargs, | ||
| ) -> Union[Any, Tuple[Any, Union[VariableDict, Dict[str, Any]]]]: | ||
| if rngs is not None: | ||
| if not _is_valid_rng(rngs) and not _is_valid_rngs(rngs): |
There was a problem hiding this comment.
Suggested change
| if not _is_valid_rng(rngs) and not _is_valid_rngs(rngs): | |
| if not _is_valid_rng(rngs): |
There was a problem hiding this comment.
they are two separate functions: _is_valid_rng checks if the rng key rngs is valid, and _is_valid_rngs checks if the dictionary mapping rngs is valid (recursively)
cgarciae
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default params rng to
.apply.Similarly to how you can get the same behavior by doing the following with
.init:This PR allows you to do the same with
.apply: