Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated rng docstring for init, apply and make_rng #3765

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Mar 15, 2024

@chiamp chiamp self-assigned this Mar 15, 2024
@chiamp chiamp force-pushed the docstring_init_apply branch 8 times, most recently from 7a14379 to 6a9ecf3 Compare March 15, 2024 23:48
@chiamp chiamp requested a review from cgarciae March 16, 2024 00:05
@cgarciae
Copy link
Collaborator

Feels like we could also improve make_rng's docstring e.g. copy some of the examples / explanations from here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (718aa8c) to head (76f6c46).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3765   +/-   ##
=======================================
  Coverage   59.12%   59.13%           
=======================================
  Files         101      101           
  Lines       12468    12469    +1     
=======================================
+ Hits         7372     7373    +1     
  Misses       5096     5096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiamp chiamp changed the title updated rng docstring for init and apply updated rng docstring for init, apply and make_rng Mar 19, 2024
@copybara-service copybara-service bot merged commit 2f76a92 into google:main Mar 19, 2024
19 checks passed
@chiamp chiamp deleted the docstring_init_apply branch March 19, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants