-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update WONK axis to close issue #2741 #2765
Conversation
Can you explain the Normal clash? I don't ever see font-style applying to this axis, and "the wonky axis is non wonky" sounds worse to me than "the wonky axis is normal" I agree with the axis label change, because it's shorter and simpler. |
There wouldn’t ever be a directly clash as far as I know; it’s more that I see "Normal" as sort of a significant word for font styling, and that significance is on the Italic axis due to CSS. In this specific case, I see the bigger reason actually being that Wonky/NonWonky make more sense in a potential STAT-based font menu. The default of this axis is intended by @sponcey to be Wonky/ |
(Side note: this axis is somewhat like the Cursive |
I think, like fvar, it's better to start out with less, and perhaps add in more later. So let's just not have any fallbacks. If the 0.5 value is "auto" then that should be the default, I guess |
Similarly i wonder if we should remove the fallbacks from https://github.com/google/fonts/blob/master/axisregistry/cursive.textproto |
Maybe I’m unsure what Also, just to be clear,
By contrast,
Not sure whether this impacts whether they have fallback names or not, but it is my understanding that |
We have several axes with 0=normal, as default, and it makes sense because the default value gets elided in the STAT and therefore don’t appear in the instance names. If you want wonky and cursive to work the same way, and to be consistent with the rest of the axis a registry, it would be: Wonk[0]=normal Crsv[0]=normal (With appropriate ranges and elided values in the STAT.) The default and the origin would also be consistent (Fraunces Regular), with all axes set up to Regular/Normal/Roman. |
But I maybe didn’t understand something.. Is the Regular master already wonky? |
Please no. This would break both typefaces. Neither of them work quite as 0="normal", 1="styled". Please see my comment above for a description of how they work. Just like not every font should look the same, not every font should act the same.
Short answer: yes. Long answer for anyone who is interested in understanding this subject a little further: In Fraunces, there isn’t a "Regular master" per se – it defines the corners with 8 sources/masters:
It has the same in Italics. (Not that this should dictate the defaults in the final variable font, but) the fonts are drawn to have the “Wonky” glyphs as defaults, e.g. the wonky They may help show the designer’s intent. However, I also have to say that the way sources are drawn shouldn’t necessarily determine what is or isn’t the default in final variable font. Sometimes, things are just drawn in a certain way for convenience or to cover legacy software (more on this in a moment). The designspace <rule name="NonWonky">
<!-- If the opsz is <18, activate NonWonky glyphs -->
<conditionset>
<condition name="Optical Size" minimum="9" maximum="18"/>
<condition name="Weight" minimum="100" maximum="900"/>
<condition name="Softness" minimum="0" maximum="100"/>
</conditionset>
<!-- If WONK is < 0.49, activate NonWonky glyphs -->
<conditionset>
<condition name="Wonky" minimum="0" maximum="0.490000"/>
</conditionset>
<!--Glyph substitutions -->
<sub name="ampersand" with="ampersand.alt"/>
<sub name="h" with="h.alt"/>
<!-- etc --> Full rule at Fraunces.designspace, Lines 29-L64 I say that “the way sources are drawn shouldn’t necessarily determine what is or isn’t the default in the final variable font,” because Recursive is a little different. Because it fits Mono & Sans styles into a single variable font, the default glyphs in the sources aren’t the default for any of the styles, but rather shapes that are acceptable if software ignores or can’t parse the This way, if a user opens Recursive on an old OS or app that ignores Similarly, I suspect that Fraunces was drawn with Wonk as default partly because it is at heart a display font based on fonts like Windsor and so intends these to be default. The more-normal, NonWonky shapes are then needed in the Text styles to make small running text more readable, or there if a user wishes to use large sizes of Fraunces in a way that is a bit more formal. One thought: instead of “Wonky” & “NonWonky” we could instead call the @sponcey, what do you think? |
👍 vote on "Formal". Also I like that it rhymes with "Normal" :P |
Nice! It sounds good to me, too. I’ll update this PR & Fraunces to fit that. Thanks for weighing in. Hopefully once this is updated, the team agrees and we can merge it. |
I wonder if the antonym of wonky is true... |
Hmm, I think it is fairly true. The main reason I can think that “NonWonky” is better than “Formal” is that the term “informal” is used by some to describe display styles that are offshoots of standard fonts. TypeMedia teacher Peter Verheul uses this term a lot, so potentially, someone may come along with a |
(I would add that “Normal” doesn’t seem to be much truer of an antonym to “Wonky” than “Formal” is. But, in the way “Wonky” is used in Fraunces, I think that either are antonyms, but because “Normal” incorrectly suggests a default, it is untrue.) |
So, I’m quite convinced that @davelab6 do you think I should change this to |
My suggestion was "True". Like when you "true up" a wonky bicycle sheet. |
@sponcey what's your final preference? |
Hmm. "True" seems a little more esoteric to me... maybe not as straightforward as "Wonky" and "NonWonky". I think I would prefer the later. |
axisregistry/wonkiness.textproto
Outdated
min_value: 0 | ||
max_value: 1 | ||
default_value: 0 | ||
precision: 0 | ||
fallback { | ||
name: "Normal" | ||
name: "NonWonky" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces to match others, e.g. "Extra Light" not "ExtraLight."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want "Not Wonky" over "Non Wonky"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thundernixon, does this change (noT instead of Non) would require to regenerate the fonts with a new stat table ie. go through the all process again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space is mandatory so if that's true you can't get out of going through the process again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the fonts we send, we don't have space for any fallback names. So the space would be added only in the axis registry. Although a difference of letter may be a bigger inconsistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m okay to rebuild the fonts to change this if needed, once we land on a solution. 🙂
Hmm, as for "Not Wonky" vs "Non Wonky," I think it could probably go either way. I gravitate towards "Non Wonky" because non- is a prefix, and in my head this binds it better as a single style descriptor, whereas "Not Wonky" sounds more like a statement or near-sentence. I can’t really decide whether there is a meaningful difference between "The font style is nonwonky" and "The font style is not wonky." To me, using specific style terms as single words does help suggest that they are specific values, rather than generalized statements. E.g. "The font weight is SemiBold" indicates a specific wght of 600, whereas "The font weight is Semi Bold" suggests that the weight is somewhere less than 700.
Perhaps, though, an important thing I got wrong in "NonWonky" is that it mistreats the prefix. It should probably be a choice between "Not Wonky" and "Nonwonky." I somewhat lean to the latter, but I don’t have a strong feeling one way or the other. I just want to get this font out to The People, and will happily accept any decision.
"Normal" seems like it could be a position that applies to many axes; it's where the text isn't , the intersection of various axes in some sense. That said, as long as you fix the spacing, LGTM. |
I’ve added a space. If we’re okay with |
Thanks @rsheeter for approving! |
Summary:
0–1
,false / partly true / true
axes, so they should probably all have adjectives for namesfont-style
in CSSSee #2741 for details.