Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastering for Google Fonts & GitHub Releases #253

Merged
merged 43 commits into from
Oct 28, 2020

Conversation

arrowtype
Copy link
Contributor

@arrowtype arrowtype commented Oct 26, 2020

NOTE: We should wait for google/fonts#2765 to settle & merge before we merge this PR. Still, I’ll open it to get the process started.

This series of commits adds & organizes build scripts, documentation, and release-ready font files. Notes/details of work done are at arrowtype#1.

Changes to UFO sources are minimized to just the things the make the final font naming work:

  • adjusting family & style names
  • adjusting major & minor version numbers
  • caret anchors were added to ligatures, so that ligature carets can be added once ufo2ft supports this

The designspace files have been significantly adjusted to enable proper naming & axis values for Google Fonts.

A make-release.sh script has also been added to enable easy GitHub Release updates. See arrowtype#2 for details.

Before we merge, I will:

  • Update the WONK axis to Wonky/Formal naming Maybe. I think either work, though I’m leaning back towards “NonWonky” as the better choice.
  • Add to build scripts to include font-v commit-stamping to font files, even those not in a release folder (it has occurred to me while making this PR that this would be a handy addition)
  • Update this PR when the axis questions are resolved & it is properly ready to merge

@arrowtype
Copy link
Contributor Author

arrowtype commented Oct 28, 2020

Okay, so I think that maybe it would make sense to merge this & test the build scripts.

google/fonts#2765 (comment) is still open and somewhat uncertain. BUT, even if we later learn that NonWonky should be changed to Formal or is requested by GF to change back to Normal, it will be an extremely small change to the Fraunces fonts, potentially changing a name in the STAT table, which is note yet used by any end-user software that I know of. If we do change this STAT naming, I can make another quick PR to update that here, and we can release it as 1.001.

So, as far as I know, this update is solid and these fonts are solid, and there’s no reason to hold it back from people who are probably eager to get v1.000 of Fraunces! The only remaining issues will probably only be caught by @sponcey running the build & release scripts, and by users trying out the fonts on their own and reporting things missed by FontBakery & our manual tests.

@sponcey
Copy link
Collaborator

sponcey commented Oct 28, 2020

Sounds good! I'll merge this, and build the fonts and see if everything is good :)

@sponcey sponcey merged commit 0caad6b into undercasetype:master Oct 28, 2020
@arrowtype
Copy link
Contributor Author

Cool! Sounds good.

@sponcey
Copy link
Collaborator

sponcey commented Oct 28, 2020

@arrowtype I ran the build script and it got hung up on this line:

sources/build-scripts/make-woff2s.sh: line 20: woff2_compress: command not found

I went to the repo listed in the script and followed those instructions on installation. I ran these lines:

git clone --recursive https://github.com/google/woff2.git
cd woff2
make clean all

I assume that was all I needed to do? Is there another part I'm missing?

@arrowtype
Copy link
Contributor Author

Oh, nice work! Yes, that is basically what I was going to recommend.

(You may also have to close & reopen the terminal you are using, potentially.)

Did that work to get woff2s generating? If so, I can add it into the setup instructions in the readme.

@arrowtype
Copy link
Contributor Author

Added in #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants