Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reemkufi: v1.0 #3302

Merged
merged 1 commit into from
Apr 13, 2021
Merged

reemkufi: v1.0 #3302

merged 1 commit into from
Apr 13, 2021

Conversation

khaledhosny
Copy link
Contributor

Reem Kufi is now a variable font with weight master. The previous version on GF does not install on Windows, FWIW.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 13, 2021

Thanks for updating the metadata file as well.

@m4rc1e m4rc1e merged commit f99bdc9 into google:main Apr 13, 2021
@khaledhosny khaledhosny deleted the reemkufi-v1.0 branch April 13, 2021 18:19
@thlinard
Copy link
Contributor

In MS Office for Mac (#3267 related):

ReemKufi

@khaledhosny
Copy link
Contributor Author

I have no idea what to do with this. The font is designed with Glyphs and built with fontmake, what do I need to fix?

@thlinard
Copy link
Contributor

I have no idea what to do with this. The font is designed with Glyphs and built with fontmake, what do I need to fix?

Hi @khaledhosny
The STAT table is almost empty. gftools fix-vf-meta will correct it.

@khaledhosny
Copy link
Contributor Author

Then fontmake should generate one in the first place, I don’t want to add more steps to the already complicated build.

@thlinard
Copy link
Contributor

Oh yes, it should. In the meantime, here is the result after gftools fix-vf-meta:
Reem Kufi

@khaledhosny
Copy link
Contributor Author

fonttools/fonttools#1507

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 26, 2021

There's also gftools gen-stat which is the successor to fix-vf-meta. It will create STAT tables for a VF family based on our Axis Registry.

@thlinard
Copy link
Contributor

Hi Marc,
Where can I find documentation for gftools gen-stat?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 26, 2021

gftools/stat.py: https://github.com/googlefonts/gftools/blob/main/Lib/gftools/stat.py#L1-L14

gftools/bin/gftools-gen-stat.py: https://github.com/googlefonts/gftools/blob/main/bin/gftools-gen-stat.py#L2-L41

@thlinard
Copy link
Contributor

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I Font Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants