Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Shoulders Text: Version 2.000 added #3432

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

vv-monsalve
Copy link
Collaborator

236ef44: [gftools-packager] Big Shoulders Text: Version 2.000 added

59f64ca: [gftools-packager] ofl/bigshoulderstext remove METADATA "source". #2587

@gf-bot

This comment has been minimized.

@vv-monsalve
Copy link
Collaborator Author

Updated

Big Shoulders Text: Version 2.000 added


979bd77: [gftools-packager] Big Shoulders Text: Version 2.000 added

d92eafe: [gftools-packager] ofl/bigshoulderstext remove METADATA "source". #2587

@vv-monsalve vv-monsalve force-pushed the gftools_packager_ofl_bigshoulderstext branch from 59f64ca to d92eafe Compare May 21, 2021 03:12
@gf-bot

This comment has been minimized.

@vv-monsalve
Copy link
Collaborator Author

This PR upgrades Big Shoulders into a Variable Font.

@m4rc1e
Copy link
Collaborator

m4rc1e commented May 24, 2021

Thanks!

The horn has moved for all glyphs.

horn

Is this intentional?

@vv-monsalve
Copy link
Collaborator Author

Is this intentional?

Yes, is part of the Vietnamese improvements done by the designer

@vv-monsalve vv-monsalve marked this pull request as draft May 26, 2021 16:09
@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 7, 2021

@vv-monsalve Are these prs still draft?

@vv-monsalve
Copy link
Collaborator Author

@vv-monsalve Are these prs still draft?

Yes, the designer is checking the ExtraLight weight

@vv-monsalve
Copy link
Collaborator Author

Updated

Big Shoulders Text: Version 2.002 added


2eef182: [gftools-packager] Big Shoulders Text: Version 2.002 added

4ba6cba: [gftools-packager] ofl/bigshoulderstext remove METADATA "source". #2587

@vv-monsalve vv-monsalve force-pushed the gftools_packager_ofl_bigshoulderstext branch from d92eafe to 4ba6cba Compare June 25, 2021 14:36
@vv-monsalve vv-monsalve marked this pull request as ready for review June 25, 2021 14:51
@vv-monsalve
Copy link
Collaborator Author

The font includes now the ExtraLight Instance.

@RosaWagner

This comment has been minimized.

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder and removed - Ready for Review labels Jul 15, 2021
@RosaWagner
Copy link
Contributor

So indeed, the opsz axis shouldn't appear in the STAT, but this is a problem with the builder, so we gonna try to implement a variable slicer in there that does it correctly.

@RosaWagner RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs confirmation from upstream or onboarder labels Jul 29, 2021
@vv-monsalve
Copy link
Collaborator Author

Updated

Big Shoulders Text: Version 2.002 added


04323d4: [gftools-packager] Big Shoulders Text: Version 2.002 added

d31dd2c: [gftools-packager] ofl/bigshoulderstext remove METADATA "source". #2587

@vv-monsalve vv-monsalve force-pushed the gftools_packager_ofl_bigshoulderstext branch from 4ba6cba to d31dd2c Compare September 2, 2021 22:58
@vv-monsalve vv-monsalve removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Sep 2, 2021
@vv-monsalve
Copy link
Collaborator Author

So indeed, the opsz axis shouldn't appear in the STAT, but this is a problem with the builder, so we gonna try to implement a variable slicer in there that does it correctly.

The PR has been updated to solve this.

@gf-bot
Copy link

gf-bot commented Sep 2, 2021

Fontbakery report

Fontbakery version: 0.8.2

[8] BigShouldersText[wght].ttf
WARN: Is there kerning info for non-ligated sequences?
--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + i
    • i + f
    • f + l
    • l + f
    • i + l

    [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters.
--- Rationale ---
According to a GlyphsApp tutorial [1], in order to make sure all versions of
Windows recognize it as a valid font file, we must make sure that the
concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style
(NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20
characters.
After discussing the problem in more detail at `FontBakery issue #2179 [2] we
decided that allowing up to 27 chars would still be on the safe side, though.
[1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances
[2] https://github.com/googlefonts/fontbakery/issues/2179
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Big Shoulders Text Thin' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description.
--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if OS/2 xAvgCharWidth is correct.
  • com.google.fonts/check/xavgcharwidth

  • WARN OS/2 xAvgCharWidth is 549 but it should be 664 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]

WARN: Does the font have a DSIG table?
--- Rationale ---
Microsoft Office 2013 and below products expect fonts to have a digital
signature declared in a DSIG table in order to implement OpenType features. The
EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not
impact Microsoft Office 2016 and above products.
As we approach the EOL date, it is now considered better to completely remove
the table.
But if you still want your font to support OpenType features on Office 2013,
then you may find it handy to add a fake signature on a dummy DSIG table by
running one of the helper scripts provided at
https://github.com/googlefonts/gftools
Reference: https://github.com/googlefonts/fontbakery/issues/1845
  • WARN This font has a digital signature (DSIG table) which is only required - even if only a dummy placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table. [code: found-DSIG]
WARN: Are there any misaligned on-curve points?
--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • ampersand (U+0026): X=704.0,Y=2.0 (should be at baseline 0?)
    • f (U+0066): X=470.0,Y=1602.0 (should be at cap-height 1600?)
    • t (U+0074): X=441.0,Y=-2.0 (should be at baseline 0?)
    • registered (U+00AE): X=572.5,Y=1598.5 (should be at cap-height 1600?)
    • registered (U+00AE): X=210.5,Y=1599.0 (should be at cap-height 1600?)
    • iogonek (U+012F): X=120.0,Y=2.0 (should be at baseline 0?)
    • iogonek (U+012F): X=200.0,Y=2.0 (should be at baseline 0?)
    • uni0163 (U+0163): X=441.0,Y=-2.0 (should be at baseline 0?)
    • tcaron (U+0165): X=441.0,Y=-2.0 (should be at baseline 0?)
    • tbar (U+0167): X=441.0,Y=-2.0 (should be at baseline 0?) and 21 more. [code: found-misalignments]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 8 49 9 152 0
0% 0% 4% 22% 4% 70% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit 7f3f5f3 into main Sep 8, 2021
@m4rc1e m4rc1e deleted the gftools_packager_ofl_bigshoulderstext branch September 8, 2021 09:41
@RosaWagner RosaWagner added --- to_production III VF Replacement Replace an existing family of static fonts with variable fonts --- Live Font is visible on API and removed --- to_sandbox labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I Font Upgrade III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Big Shoulders families to 'wght' VF
4 participants