Big Shoulders Inline Text: Version 2.000 added #3437

vv-monsalve · 2021-05-21T04:10:27Z

9b91199: [gftools-packager] Big Shoulders Inline Text: Version 2.000 added

Big Shoulders Inline Text Version 2.000 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@41153e6.

8dd06a4: [gftools-packager] ofl/bigshouldersinlinetext remove METADATA "source". #2587

vv-monsalve · 2021-05-21T04:11:13Z

This PR upgrades Big Shoulders Inline Text into a Variable Font.
OFL.txt and Description files were added in #3432

vv-monsalve · 2021-05-26T14:16:40Z

Updated

Big Shoulders Inline Text: Version 2.000 added

0ba2e16: [gftools-packager] Big Shoulders Inline Text: Version 2.000 added

Big Shoulders Inline Text Version 2.000 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@41153e6.

e694342: [gftools-packager] ofl/bigshouldersinlinetext remove METADATA "source". #2587

vv-monsalve · 2021-06-25T14:23:22Z

Updated

Big Shoulders Inline Text: Version 2.002 added

703976b: [gftools-packager] Big Shoulders Inline Text: Version 2.002 added

Big Shoulders Inline Text Version 2.002 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@c32776c.

e352a8c: [gftools-packager] ofl/bigshouldersinlinetext remove METADATA "source". #2587

vv-monsalve · 2021-06-25T14:34:36Z

The font includes now the ExtraLight Instance.
It could be merged now.

* Big Shoulders Inline Text Version 2.002 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@2f924dd.

#2587

vv-monsalve · 2021-09-02T23:31:41Z

Updated

Big Shoulders Inline Text: Version 2.002 added

dfd3368: [gftools-packager] Big Shoulders Inline Text: Version 2.002 added

Big Shoulders Inline Text Version 2.002 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@2f924dd.

252c49a: [gftools-packager] ofl/bigshouldersinlinetext remove METADATA "source". #2587

vv-monsalve · 2021-09-02T23:32:04Z

The PR was updated to solve STAT table (with no opsz axis) as mentioned in #3434

gf-bot · 2021-09-02T23:44:34Z

Fontbakery report

Fontbakery version: 0.8.2

[9] BigShouldersInlineText[wght].ttf

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.

com.google.fonts/check/unitsperem_strict

--- Rationale ---
Even though the OpenType spec allows unitsPerEm to be any value between 16 and
16384, the Google Fonts project aims at a narrower set of reasonable values.
The spec suggests usage of powers of two in order to get some performance
improvements on legacy renderers, so those values are acceptable.
But values of 500 or 1000 are also acceptable, with the added benefit that it
makes upm math easier for designers, while the performance hit of not using a
power of two is most likely negligible nowadays.
Additionally, values above 2048 would likely result in unreasonable filesize
increases.

⚠ WARN Font em size (unitsPerEm) is 4000 which may be too large (causing filesize bloat), unless you are sure that the detail level in this font requires that much precision. [code: large-value]

⚠ WARN: Is there kerning info for non-ligated sequences?

com.google.fonts/check/kerning_for_non_ligated_sequences

--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- i + f
- f + l
- l + f
- i + l
[code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters.

com.google.fonts/check/name/family_and_style_max_length

--- Rationale ---
According to a GlyphsApp tutorial [1], in order to make sure all versions of
Windows recognize it as a valid font file, we must make sure that the
concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style
(NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20
characters.
After discussing the problem in more detail at `FontBakery issue #2179 [2] we
decided that allowing up to 27 chars would still be on the safe side, though.
[1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances
[2] https://github.com/googlefonts/fontbakery/issues/2179

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
FONT_FAMILY_NAME = 'Big Shoulders Inline Text Thin' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts

com.google.fonts/check/repo/vf_has_static_fonts

--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure Stylistic Sets have description.

com.google.fonts/check/stylisticset_description

--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.

⚠ WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.

com.google.fonts/check/meta/script_lang_tags

--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.

⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Checking unitsPerEm value is reasonable.

com.google.fonts/check/unitsperem

--- Rationale ---
According to the OpenType spec:
The value of unitsPerEm at the head table must be a value between 16 and 16384.
Any value in this range is valid.
In fonts that have TrueType outlines, a power of 2 is recommended as this allows
performance optimizations in some rasterizers.
But 1000 is a commonly used value. And 2000 may become increasingly more common
on Variable Fonts.

⚠ WARN In order to optimize performance on some legacy renderers, the value of unitsPerEm at the head table should idealy be a power of between 16 to 16384. And values of 1000 and 2000 are also common and may be just fine as well. But we got 4000 instead. [code: suboptimal]

⚠ WARN: Check if OS/2 xAvgCharWidth is correct.

com.google.fonts/check/xavgcharwidth
⚠ WARN OS/2 xAvgCharWidth is 1072 but it should be 1303 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]

⚠ WARN: Does the font have a DSIG table?

com.google.fonts/check/dsig

--- Rationale ---
Microsoft Office 2013 and below products expect fonts to have a digital
signature declared in a DSIG table in order to implement OpenType features. The
EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not
impact Microsoft Office 2016 and above products.
As we approach the EOL date, it is now considered better to completely remove
the table.
But if you still want your font to support OpenType features on Office 2013,
then you may find it handy to add a fake signature on a dummy DSIG table by
running one of the helper scripts provided at
https://github.com/googlefonts/gftools
Reference: https://github.com/googlefonts/fontbakery/issues/1845

⚠ WARN This font has a digital signature (DSIG table) which is only required - even if only a dummy placeholder - on old programs like MS Office 2013 in order to work properly.
The current recommendation is to completely remove the DSIG table. [code: found-DSIG]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	9	49	9	151	0
0%	0%	4%	22%	4%	69%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

gf-bot · 2021-09-08T09:52:09Z

Fontbakery report

Fontbakery version: 0.8.2

[9] BigShouldersInlineText[wght].ttf

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.

com.google.fonts/check/unitsperem_strict

--- Rationale ---
Even though the OpenType spec allows unitsPerEm to be any value between 16 and
16384, the Google Fonts project aims at a narrower set of reasonable values.
The spec suggests usage of powers of two in order to get some performance
improvements on legacy renderers, so those values are acceptable.
But values of 500 or 1000 are also acceptable, with the added benefit that it
makes upm math easier for designers, while the performance hit of not using a
power of two is most likely negligible nowadays.
Additionally, values above 2048 would likely result in unreasonable filesize
increases.

⚠ WARN Font em size (unitsPerEm) is 4000 which may be too large (causing filesize bloat), unless you are sure that the detail level in this font requires that much precision. [code: large-value]

⚠ WARN: Is there kerning info for non-ligated sequences?

com.google.fonts/check/kerning_for_non_ligated_sequences

--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- i + f
- f + l
- l + f
- i + l
[code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters.

com.google.fonts/check/name/family_and_style_max_length

--- Rationale ---
According to a GlyphsApp tutorial [1], in order to make sure all versions of
Windows recognize it as a valid font file, we must make sure that the
concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style
(NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20
characters.
After discussing the problem in more detail at `FontBakery issue #2179 [2] we
decided that allowing up to 27 chars would still be on the safe side, though.
[1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances
[2] https://github.com/googlefonts/fontbakery/issues/2179

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
FONT_FAMILY_NAME = 'Big Shoulders Inline Text Thin' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts

com.google.fonts/check/repo/vf_has_static_fonts

--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure Stylistic Sets have description.

com.google.fonts/check/stylisticset_description

--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.

⚠ WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.

com.google.fonts/check/meta/script_lang_tags

--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.

⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Checking unitsPerEm value is reasonable.

com.google.fonts/check/unitsperem

--- Rationale ---
According to the OpenType spec:
The value of unitsPerEm at the head table must be a value between 16 and 16384.
Any value in this range is valid.
In fonts that have TrueType outlines, a power of 2 is recommended as this allows
performance optimizations in some rasterizers.
But 1000 is a commonly used value. And 2000 may become increasingly more common
on Variable Fonts.

⚠ WARN In order to optimize performance on some legacy renderers, the value of unitsPerEm at the head table should idealy be a power of between 16 to 16384. And values of 1000 and 2000 are also common and may be just fine as well. But we got 4000 instead. [code: suboptimal]

⚠ WARN: Check if OS/2 xAvgCharWidth is correct.

com.google.fonts/check/xavgcharwidth
⚠ WARN OS/2 xAvgCharWidth is 1072 but it should be 1303 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]

⚠ WARN: Does the font have a DSIG table?

com.google.fonts/check/dsig

--- Rationale ---
Microsoft Office 2013 and below products expect fonts to have a digital
signature declared in a DSIG table in order to implement OpenType features. The
EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not
impact Microsoft Office 2016 and above products.
As we approach the EOL date, it is now considered better to completely remove
the table.
But if you still want your font to support OpenType features on Office 2013,
then you may find it handy to add a fake signature on a dummy DSIG table by
running one of the helper scripts provided at
https://github.com/googlefonts/gftools
Reference: https://github.com/googlefonts/fontbakery/issues/1845

⚠ WARN This font has a digital signature (DSIG table) which is only required - even if only a dummy placeholder - on old programs like MS Office 2013 in order to work properly.
The current recommendation is to completely remove the DSIG table. [code: found-DSIG]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	9	49	9	151	0
0%	0%	4%	22%	4%	69%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

vv-monsalve requested a review from m4rc1e May 21, 2021 04:11

vv-monsalve self-assigned this May 21, 2021

vv-monsalve added - Ready for Review I Font Upgrade labels May 21, 2021

vv-monsalve linked an issue May 21, 2021 that may be closed by this pull request

Update Big Shoulders families to 'wght' VF #3433

Closed

6 tasks

vv-monsalve mentioned this pull request May 21, 2021

Update Big Shoulders families to 'wght' VF #3433

Closed

6 tasks

This comment has been minimized.

Sign in to view

thlinard mentioned this pull request May 21, 2021

Big Shoulders Stencil Display: Version 2.000 added #3436

Merged

RosaWagner mentioned this pull request May 26, 2021

[code: xAvgCharWidth-wrong] I don'tknow how to fix this fonttools/fontbakery#3309

Closed

vv-monsalve force-pushed the gftools_packager_ofl_bigshouldersinlinetext branch from 8dd06a4 to e694342 Compare May 26, 2021 14:16

This comment has been minimized.

Sign in to view

vv-monsalve marked this pull request as draft May 26, 2021 16:09

vv-monsalve added - In Progress and removed - Ready for Review labels May 26, 2021

vv-monsalve force-pushed the gftools_packager_ofl_bigshouldersinlinetext branch from e694342 to e352a8c Compare June 25, 2021 14:23

vv-monsalve marked this pull request as ready for review June 25, 2021 14:24

vv-monsalve added - Ready for Review and removed - In Progress labels Jun 25, 2021

This comment has been minimized.

Sign in to view

RosaWagner added -- Needs confirmation from upstream or onboarder and removed - Ready for Review labels Jul 15, 2021

RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs confirmation from upstream or onboarder labels Jul 29, 2021

vv-monsalve added 2 commits September 2, 2021 18:31

[gftools-packager] Big Shoulders Inline Text: Version 2.002 added

dfd3368

* Big Shoulders Inline Text Version 2.002 taken from the upstream repo https://github.com/xotypeco/big_shoulders at commit xotypeco/big_shoulders@2f924dd.

[gftools-packager] ofl/bigshouldersinlinetext remove METADATA "source".

252c49a

#2587

vv-monsalve force-pushed the gftools_packager_ofl_bigshouldersinlinetext branch from e352a8c to 252c49a Compare September 2, 2021 23:31

vv-monsalve added - Ready for Review and removed -- Needs Upstream Resolution Upstream fix required before moving forward labels Sep 2, 2021

vv-monsalve requested a review from RosaWagner September 2, 2021 23:34

m4rc1e merged commit 7123620 into main Sep 8, 2021

m4rc1e deleted the gftools_packager_ofl_bigshouldersinlinetext branch September 8, 2021 09:57

m4rc1e added --- to_sandbox and removed - Ready for Review labels Sep 8, 2021

RosaWagner added --- to_production III VF Replacement Replace an existing family of static fonts with variable fonts --- Live Font is visible on API and removed --- to_sandbox labels Sep 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Big Shoulders Inline Text: Version 2.000 added #3437

Big Shoulders Inline Text: Version 2.000 added #3437

vv-monsalve commented May 21, 2021

vv-monsalve commented May 21, 2021

This comment has been minimized.

vv-monsalve commented May 26, 2021

This comment has been minimized.

vv-monsalve commented Jun 25, 2021

vv-monsalve commented Jun 25, 2021

This comment has been minimized.

vv-monsalve commented Sep 2, 2021

vv-monsalve commented Sep 2, 2021

gf-bot commented Sep 2, 2021

gf-bot commented Sep 8, 2021

Big Shoulders Inline Text: Version 2.000 added #3437

Big Shoulders Inline Text: Version 2.000 added #3437

Conversation

vv-monsalve commented May 21, 2021

vv-monsalve commented May 21, 2021

This comment has been minimized.

vv-monsalve commented May 26, 2021

Big Shoulders Inline Text: Version 2.000 added

This comment has been minimized.

vv-monsalve commented Jun 25, 2021

Big Shoulders Inline Text: Version 2.002 added

vv-monsalve commented Jun 25, 2021

This comment has been minimized.

vv-monsalve commented Sep 2, 2021

Big Shoulders Inline Text: Version 2.002 added

vv-monsalve commented Sep 2, 2021

gf-bot commented Sep 2, 2021

Fontbakery report

Summary

gf-bot commented Sep 8, 2021

Fontbakery report

Summary