-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosario v1.201 (stat fix) #3651
Conversation
Medium weight added
Fontbakery reportFontbakery version: 0.8.0 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/main/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[9] Rosario-Italic[wght].ttf🔥 FAIL: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.
🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table?
🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table?
⚠ WARN: Check copyright namerecords match license file.--- Rationale --- A known licensing description must be provided in the NameID 14 (LICENSE DESCRIPTION) entries of the name table. The source of truth for this check (to determine which license is in use) is a file placed side-by-side to your font project including the licensing terms. Depending on the chosen license, one of the following string snippets is expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name table: - "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" - "Licensed under the Apache License, Version 2.0" - "Licensed under the Ubuntu Font Licence 1.0." Currently accepted licenses are Apache or Open Font License. For a small set of legacy families the Ubuntu Font License may be acceptable as well. When in doubt, please choose OFL for new font projects.
⚠ WARN: License URL matches License text on name table?--- Rationale --- A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry of the name table. The source of truth for this check is the licensing text found on the NameID 13 entry (LICENSE DESCRIPTION). The string snippets used for detecting licensing terms are: - "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" - "Licensed under the Apache License, Version 2.0" - "Licensed under the Ubuntu Font Licence 1.0." Currently accepted licenses are Apache or Open Font License. For a small set of legacy families the Ubuntu Font License may be acceptable as well. When in doubt, please choose OFL for new font projects.
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp or UFOs, ligature carets can be defined as anchors with names starting with 'caret_'. These can be compiled with fontmake as of version v2.4.0.
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.--- Rationale --- We want to ensure that any significant changes to the font family are properly mentioned in the DESCRIPTION file. In general, it means that the contents of the DESCRIPTION.en_us.html file will typically change if when font files are updated. Please treat this check as a reminder to do so whenever appropriate!
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.--- Rationale --- The OpenType 'meta' table originated at Apple. Microsoft added it to OT with just two DataMap records: - dlng: comma-separated ScriptLangTags that indicate which scripts, or languages and scripts, with possible variants, the font is designed for - slng: comma-separated ScriptLangTags that indicate which scripts, or languages and scripts, with possible variants, the font supports The slng structure is intended to describe which languages and scripts the font overall supports. For example, a Traditional Chinese font that also contains Latin characters, can indicate Hant,Latn, showing that it supports Hant, the Traditional Chinese variant of the Hani script, and it also supports the Latn script The dlng structure is far more interesting. A font may contain various glyphs, but only a particular subset of the glyphs may be truly "leading" in the design, while other glyphs may have been included for technical reasons. Such a Traditional Chinese font could only list Hant there, showing that it’s designed for Traditional Chinese, but the font would omit Latn, because the developers don’t think the font is really recommended for purely Latin-script use. The tags used in the structures can comprise just script, or also language and script. For example, if a font has Bulgarian Cyrillic alternates in the locl feature for the cyrl BGR OT languagesystem, it could also indicate in dlng explicitly that it supports bul-Cyrl. (Note that the scripts and languages in meta use the ISO language and script codes, not the OpenType ones). This check ensures that the font has the meta table containing the slng and dlng structures. All families in the Google Fonts collection should contain the 'meta' table. Windows 10 already uses it when deciding on which fonts to fall back to. The Google Fonts API and also other environments could use the data for smarter filtering. Most importantly, those entries should be added to the Noto fonts. In the font making process, some environments store this data in external files already. But the meta table provides a convenient way to store this inside the font file, so some tools may add the data, and unrelated tools may read this data. This makes the solution much more portable and universal.
[8] Rosario[wght].ttf🔥 FAIL: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.
🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table?
🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table?
⚠ WARN: Check copyright namerecords match license file.--- Rationale --- A known licensing description must be provided in the NameID 14 (LICENSE DESCRIPTION) entries of the name table. The source of truth for this check (to determine which license is in use) is a file placed side-by-side to your font project including the licensing terms. Depending on the chosen license, one of the following string snippets is expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name table: - "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" - "Licensed under the Apache License, Version 2.0" - "Licensed under the Ubuntu Font Licence 1.0." Currently accepted licenses are Apache or Open Font License. For a small set of legacy families the Ubuntu Font License may be acceptable as well. When in doubt, please choose OFL for new font projects.
⚠ WARN: License URL matches License text on name table?--- Rationale --- A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry of the name table. The source of truth for this check is the licensing text found on the NameID 13 entry (LICENSE DESCRIPTION). The string snippets used for detecting licensing terms are: - "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" - "Licensed under the Apache License, Version 2.0" - "Licensed under the Ubuntu Font Licence 1.0." Currently accepted licenses are Apache or Open Font License. For a small set of legacy families the Ubuntu Font License may be acceptable as well. When in doubt, please choose OFL for new font projects.
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp or UFOs, ligature carets can be defined as anchors with names starting with 'caret_'. These can be compiled with fontmake as of version v2.4.0.
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.--- Rationale --- The OpenType 'meta' table originated at Apple. Microsoft added it to OT with just two DataMap records: - dlng: comma-separated ScriptLangTags that indicate which scripts, or languages and scripts, with possible variants, the font is designed for - slng: comma-separated ScriptLangTags that indicate which scripts, or languages and scripts, with possible variants, the font supports The slng structure is intended to describe which languages and scripts the font overall supports. For example, a Traditional Chinese font that also contains Latin characters, can indicate Hant,Latn, showing that it supports Hant, the Traditional Chinese variant of the Hani script, and it also supports the Latn script The dlng structure is far more interesting. A font may contain various glyphs, but only a particular subset of the glyphs may be truly "leading" in the design, while other glyphs may have been included for technical reasons. Such a Traditional Chinese font could only list Hant there, showing that it’s designed for Traditional Chinese, but the font would omit Latn, because the developers don’t think the font is really recommended for purely Latin-script use. The tags used in the structures can comprise just script, or also language and script. For example, if a font has Bulgarian Cyrillic alternates in the locl feature for the cyrl BGR OT languagesystem, it could also indicate in dlng explicitly that it supports bul-Cyrl. (Note that the scripts and languages in meta use the ISO language and script codes, not the OpenType ones). This check ensures that the font has the meta table containing the slng and dlng structures. All families in the Google Fonts collection should contain the 'meta' table. Windows 10 already uses it when deciding on which fonts to fall back to. The Google Fonts API and also other environments could use the data for smarter filtering. Most importantly, those entries should be added to the Noto fonts. In the font making process, some environments store this data in external files already. But the meta table provides a convenient way to store this inside the font file, so some tools may add the data, and unrelated tools may read this data. This makes the solution much more portable and universal.
Summary
Note: The following loglevels were omitted in this report:
|
update sample text for yue_Hani
* hypertype : bio added * Hypertype: links updated Co-authored-by: Rosalie Wagner <mail@rosaliewagner.com>
* artakana : bio added (designer name fixed) * Update bio.html Will make change in a separate PR focused on DelaGothic Co-authored-by: Rosalie Wagner <mail@rosaliewagner.com> Co-authored-by: Aaron <aaronbell@users.noreply.github.com>
* yangheeryu : bio added * yangheeryu : links updated Co-authored-by: Rosalie Wagner <mail@rosaliewagner.com>
* [gftools-packager] RocknRoll One: Version 1.100 added * RocknRoll One Version 1.100 taken from the upstream repo https://github.com/fontworks-fonts/RocknRoll.git at commit fontworks-fonts/RocknRoll@fdaf96f. * Update METADATA.pb * Update upstream.yaml
#2861) * [gftools-packager] Mochiy Pop One: Version 2.000; ttfautohint (v1.8.3) added * Mochiy Pop One Version 2.000; ttfautohint (v1.8.3) taken from the upstream repo https://github.com/fontdasu/Mochiypop.git at commit fontdasu/Mochiypop@2c240f5. * [gftools-packager] Mochiy Pop P One: Version 2.000; ttfautohint (v1.8.3) added * Mochiy Pop P One Version 2.000; ttfautohint (v1.8.3) taken from the upstream repo https://github.com/fontdasu/Mochiypop.git at commit fontdasu/Mochiypop@2c240f5. * Update METADATA.pb * Update METADATA.pb * [gftools-packager] Mochiy Pop One: Version 2.000; ttfautohint (v1.8.3) added * Mochiy Pop One Version 2.000; ttfautohint (v1.8.3) taken from the upstream repo https://github.com/fontdasu/Mochiypop.git at commit fontdasu/Mochiypop@9641b84. * [gftools-packager] Mochiy Pop P One: Version 2.000; ttfautohint (v1.8.3) added * Mochiy Pop P One Version 2.000; ttfautohint (v1.8.3) taken from the upstream repo https://github.com/fontdasu/Mochiypop.git at commit fontdasu/Mochiypop@9641b84. * Update METADATA.pb * Update METADATA.pb * Dehinted font files Removed hinting, set GASP table to full smooth. * Updating upstream.yaml re-adding repository_urls * Correcting odd curve issue in D / Eth
* [gftools-packager] Stick: Version 1.100 added * Stick Version 1.100 taken from the upstream repo https://github.com/fontworks-fonts/Stick.git at commit fontworks-fonts/Stick@7872941. * Update METADATA.pb * Update upstream.yaml
Contributor Covenant, version 2.0. As suggested in issue #3515
…amilies and some sample text)
…ared in many transliterations)
* [gftools-packager] El Messiri: Version 2.020 added * El Messiri Version 2.020 taken from the upstream repo https://github.com/Gue3bara/El-Messiri at commit Gue3bara/El-Messiri@553b98d. * [gftools-packager] ofl/elmessiri remove METADATA "source". #2587 * El Messiri: description updated
* [gftools-packager] Caramel: Version 1.010 added * Caramel Version 1.010 taken from the upstream repo https://github.com/googlefonts/caramel at commit googlefonts/caramel@497341c. * [gftools-packager] ofl/caramel remove METADATA "source". #2587
Delist ofl/allison per #3682
No target attributes greatvibes!
* [gftools-packager] Red Hat Mono: Version 1.021 added * Red Hat Mono Version 1.021 taken from the upstream repo https://github.com/jeremymickel/RedHatFonts at commit jeremymickel/RedHatFonts@a4bcf9d. * [gftools-packager] ofl/redhatmono remove METADATA "source". #2587
* [gftools-packager] Cherish: Version 1.005 added * Cherish Version 1.005 taken from the upstream repo https://github.com/googlefonts/cherish at commit googlefonts/cherish@fd3a5b6. * [gftools-packager] ofl/cherish remove METADATA "source". #2587
* [gftools-packager] Red Hat Display: Version 1.021 added * Red Hat Display Version 1.021 taken from the upstream repo https://github.com/jeremymickel/RedHatFonts at commit jeremymickel/RedHatFonts@a4bcf9d. * [gftools-packager] ofl/redhatdisplay remove METADATA "source". #2587
* Updated to UFR, fonts rebuilt * bumping version string * Resolved incompatibility in quotesinglbase One instance didn't have transform, so others were decomposed, causing incompatibility. Now resolved. * exo2: remove statics Co-authored-by: Marc Foley <m.foley.88@gmail.com>
* updating to UFR, fonts rebuilt * Updating metadata * Updating caron characters tcaron and dcaron rolled back to earlier version. * mavenpro: remove statics Co-authored-by: Marc Foley <m.foley.88@gmail.com>
Currently in API, Light = Regular. But now it appears as originally intended: https://github.com/Omnibus-Type/Rosario/blob/master/sources/Rosario-01.png |
Yes, appears intentional. |
Medium weight added
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1733 files changed, I think there is an issue with this PR. |
Resubmitting |
Font repro updated to the UFR format (https://github.com/aaronbell/Rosario).
PR'd to upstream.
Font files rebuilt.