Noto Sans SC 2.004

[simoncozens]

• Continuation of Update Noto Sans HK, JP, KR, SC, TC to 2.004 using variable fonts #3928
• Fonts taken from notofonts/noto-cjk@a944819 using hotfix script at https://github.com/googlefonts/noto-cjk/blob/main/google-fonts/hotfix.py

[simoncozens]

Fontbakery report

Fontbakery version: 0.8.9.dev4+g9a5535cc

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  ('wght', 1) [code: summary]

[31] NotoSansSC[wght].ttf

🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)

• 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]

🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage. (com.google.fonts/check/glyph_coverage)

• 🔥 FAIL Missing required codepoints:

  • 0x0131 (LATIN SMALL LETTER DOTLESS I)

  • 0x02C6 (MODIFIER LETTER CIRCUMFLEX ACCENT)

  • 0x02DA (RING ABOVE)

  • 0x02DC (SMALL TILDE)

  • And 0x2044 (FRACTION SLASH)
    [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

• 🔥 FAIL First line in license file is:

"copyright 2012 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)

• 🔥 FAIL The OFL.txt body text is incorrect. Please use https://github.com/googlefonts/Unified-Font-Repository/blob/main/OFL.txt as a template. You should only modify the first line. [code: incorrect-ofl-body-text]

🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)

• 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This Font Software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)

• 🔥 FAIL Font file is 34.5Mb, larger than limit 9.0Mb [code: massive-font]

🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)

• 🔥 FAIL METADATA.pb font full_name = "Noto Sans SC" does not match post_script_name = "NotoSansSC-Thin" [code: mismatch]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

• 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
  "Copyright 2020 The Familyname Project Authors (git url)"
  But instead we have got:
  "(c) 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'." [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

• 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
  But instead we have got:
  "(c) 2014-2021 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'." [code: bad-notice-format]

🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'. (com.google.fonts/check/name/rfn)

• 🔥 FAIL Name table entry ("(c) 2014-2021 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]

🔥 FAIL: Check font follows the Google Fonts CJK vertical metric schema (com.google.fonts/check/cjk_vertical_metrics)

• 🔥 FAIL hhea.ascent must match OS/2.usWinAscent [code: ascent-mismatch]
• 🔥 FAIL hhea.descent must match absolute value of OS/2.usWinDescent [code: descent-mismatch]

🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)

• 🔥 FAIL Found escaped chars at 'Source'. Please use an unicode string instead. [code: escaped-strings]
• 🔥 FAIL Found escaped chars at '(c) 2014-2021 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'.'. Please use an unicode string instead. [code: escaped-strings]

🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• 🔥 FAIL Designer Google still does not have an avatar image. Please provide one. [code: missing-avatar]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

• 🔥 FAIL Font can't render "cjy_Hans" sample text:
  "人人生而自由，在尊严和权利上一律平等。他们赋有理性和良心，并应以弟兄关系的精神相对待。
  人人生而自由，在尊严和权利上一律平等。他们赋有理性和良心，并应以弟兄关系的精神相对待。"
  [code: sample-text]
• 🔥 FAIL Font can't render "hsn_Hans" sample text:
  "人人生而自由，在尊严和权利上一律平等。他们赋有理性和良心，在得以兄弟关系的精神相对待。
  人人生而自由，在尊严和权利上一律平等。他们赋有理性和良心，在得以兄弟关系的精神相对待。"
  [code: sample-text]
• ℹ INFO No sample_glyphs on METADATA.pb [code: no-samples]

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
  • acutecomb
  • gravecomb
  • uni030C
  • And uni0307 [code: unattached-dotted-circle-marks]

⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)

• ⚠ WARN METADATA.pb: copyright field ("(c) 2014-2021 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • f + f
  • f + i
  • i + f
  • f + l
  • l + f
  • i + l

  [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:
  • glyph62395
  • glyph62605
  • glyph62022
  • glyph62621
  • glyph62947
  • glyph62722
  • glyph62179
  • glyph62042
  • glyph62575
  • glyph62955
  • And 842 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)

• ⚠ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature]
• ⚠ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]

⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)

• ⚠ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]

⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)

• ⚠ WARN The following mark characters could be in the GDEF mark glyph class:
  uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	out/fonts/ofl/notosanssc/NotoSansSC[wght].ttf
Dehinted Size	34.5Mb
Hinted Size	34.5Mb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

• ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.004;hotconv 1.0.118;makeotfexe 2.5.65603'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 2.004;hotconv 1.0.118;makeotfexe 2.5.65603"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:
  • loca
  • prep
  • BASE
  • GPOS
  • GSUB
  • gasp
  • vhea
  • And vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO out/fonts/ofl/notosanssc [code: family-path]

### Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	15	9	57	8	136	0
0%	7%	4%	25%	4%	60%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[simoncozens]

@marekjez86 Please do not merge until we agree the display name and subsets issue.

[marekjez86]

IMHO for CJK we should keep display_name. However, I have no idea why we introduced display_name... My assumption is that this is for the fonts which display name cannot be easily derived from the font name. The following fonts have this property in their .pb
notosanshk/METADATA.pb:display_name: "Noto Sans Hong Kong"
notosansjp/METADATA.pb:display_name: "Noto Sans Japanese"
notosanskr/METADATA.pb:display_name: "Noto Sans Korean"
notosanssc/METADATA.pb:display_name: "Noto Sans Simplified Chinese"
notosanstc/METADATA.pb:display_name: "Noto Sans Traditional Chinese"
notoserifjp/METADATA.pb:display_name: "Noto Serif Japanese"
notoserifkr/METADATA.pb:display_name: "Noto Serif Korean"
notoserifsc/METADATA.pb:display_name: "Noto Serif Simplified Chinese"
notoseriftc/METADATA.pb:display_name: "Noto Serif Traditional Chinese"

nototraditionalnushu/METADATA.pb:display_name: "Noto Traditional Nüshu"( ü in display name)
notosansnko/METADATA.pb:display_name: "Noto Sans N'Ko" (' as part of the name)
notosansnushu/METADATA.pb:display_name: "Noto Sans Nüshu" ( ü in display name)

Hence we should keep these (and I was wrong to merge the fonts without these).

Also, @simoncozens : you'll provide for onboarding for the serifs (including Serif HK, which doesn't exist on fonts.google.com).. Is this a correct assumption?

[vv-monsalve]

Eng request: blocked on a prod issue