Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_production.txt: Hold Noto CJK production pushes #5021

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

chrissimpkins
Copy link
Collaborator

Fonts Eng request

@chrissimpkins
Copy link
Collaborator Author

cc @vv-monsalve

Copy link
Collaborator

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider moving them into a block with a comment on the block that says they are blocked on a prod issue

@chrissimpkins
Copy link
Collaborator Author

Nit: consider moving them into a block with a comment on the block that says they are blocked on a prod issue

52ff368

@rsheeter rsheeter merged commit 91b36c9 into main Aug 2, 2022
@rsheeter rsheeter deleted the chrissimpkins-to_production branch August 2, 2022 02:22
@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Aug 3, 2022

I've removed the --- to production, added the --- blocked labels to the CJK PR, and added an Eng request: blocked on a prod issue comment on each PR. This would prevent them from getting included in the next lists until we change labels again.

I've done a new trial round on downloading the fonts from Sandbox just now; below is a list of the current status.

We could either keep blocking all of them in a batch, or perhaps we could proceed with the ones that are downloading ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants