-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Noto Serif HK 2.001 #4652
Add Noto Serif HK 2.001 #4652
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Fontbakery reportFontbakery version: 0.8.8 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[29] NotoSerifHK[wght].ttf💔 ERROR: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage. (com.google.fonts/check/glyph_coverage)
🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: Check font follows the Google Fonts CJK vertical metric schema (com.google.fonts/check/cjk_vertical_metrics)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
@marekjez86 I am going to merge this PR, please feel free to update the languages and subsets in metadata.pb if needed in an additional PR. |
@RosaWagner : My previous METADATA.pb changes dealt with all coming updates to CJK (but they were also valid for the current, so in no way at any point we had issues there). Thanks for merging. |
Eng request: blocked on a prod issue |
This is a new font for GF! I don't know why this font was not originally onboarded.