Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Noto Serif HK 2.001 #4652

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Add Noto Serif HK 2.001 #4652

merged 5 commits into from
Jun 8, 2022

Conversation

simoncozens
Copy link
Collaborator

This is a new font for GF! I don't know why this font was not originally onboarded.

@simoncozens simoncozens added II CJK Chinese, Japanese, Korean scripts - Ready for Review I New Font labels May 12, 2022
@simoncozens

This comment was marked as outdated.

@RosaWagner RosaWagner added -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required and removed - Ready for Review labels May 18, 2022
@simoncozens simoncozens added - Ready for Review and removed -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required labels Jun 1, 2022
@RosaWagner
Copy link
Contributor

Fontbakery report

Fontbakery version: 0.8.8

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[29] NotoSerifHK[wght].ttf
💔 ERROR: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 💔 ERROR Failed with KeyError: 'cjy_Hant'
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0131 (LATIN SMALL LETTER DOTLESS I)

    • 0x02C6 (MODIFIER LETTER CIRCUMFLEX ACCENT)

    • 0x02DA (RING ABOVE)

    • 0x02DC (SMALL TILDE)

    • And 0x2044 (FRACTION SLASH)
      [code: missing-codepoints]

🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
  • 🔥 FAIL Please remove the unrecognized subset 'chinese-hongkong' from the METADATA.pb file. [code: unknown-subset]
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file does not match expected format: "copyright 2017-2022 google inc. all rights reserved."
🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This Font Software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 57.1Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)
  • 🔥 FAIL METADATA.pb font full_name = "Noto Serif HK" does not match post_script_name = "NotoSerifHK-ExtraLight" [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Check font follows the Google Fonts CJK vertical metric schema (com.google.fonts/check/cjk_vertical_metrics)
  • 🔥 FAIL hhea.ascent must match OS/2.usWinAscent [code: ascent-mismatch]
  • 🔥 FAIL hhea.descent must match absolute value of OS/2.usWinDescent [code: descent-mismatch]
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • 🔥 FAIL Designer Google still does not have an avatar image. Please provide one. [code: missing-avatar]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
    • gravecomb
    • acutecomb
    • uni0307
    • And uni030C [code: unattached-dotted-circle-marks]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + i
    • i + f
    • f + l
    • l + f
    • i + l

    [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:
    • glyph62296
    • glyph65454
    • glyph61908
    • glyph65370
    • glyph65396
    • glyph65403
    • glyph62187
    • glyph62645
    • glyph62726
    • glyph62292
    • And 972 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
/Users/rosalie/Desktop/notoserifHK_qa/fonts/ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size 57.1Mb
Hinted Size 57.1Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.001;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.001;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:
    • loca
    • prep
    • BASE
    • GPOS
    • GSUB
    • gasp
    • vhea
    • And vmtx [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO /Users/rosalie/Desktop/notoserifHK_qa/fonts/ofl/notoserifhk [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
1 13 8 57 8 138 0
0% 6% 4% 25% 4% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

RosaWagner commented Jun 8, 2022

@marekjez86 I am going to merge this PR, please feel free to update the languages and subsets in metadata.pb if needed in an additional PR.

@RosaWagner RosaWagner merged commit 85bd399 into main Jun 8, 2022
@RosaWagner RosaWagner deleted the notoserifhk-2.001 branch June 8, 2022 09:06
@marekjez86
Copy link
Contributor

@RosaWagner : My previous METADATA.pb changes dealt with all coming updates to CJK (but they were also valid for the current, so in no way at any point we had issues there). Thanks for merging.

@vv-monsalve
Copy link
Collaborator

Eng request: blocked on a prod issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I New Font II CJK Chinese, Japanese, Korean scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants