Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif HK: Version 2.004-H1 added #5342

Closed
wants to merge 1 commit into from
Closed

Conversation

simoncozens
Copy link
Collaborator

This replaces the binary of Noto Serif HK from one based on NotoSerifCJKhk-VF.ttf to one based on Subset/NotoSerifHK-VF.ttf.

@RosaWagner
Copy link
Contributor

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[32] NotoSerifHK[wght].ttf
💔 ERROR: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 💔 ERROR Failed with KeyError: 'cjy_Hant'
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

    • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

    • And 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
  • 🔥 FAIL Please remove the unrecognized subset 'chinese-hongkong' from the METADATA.pb file. [code: unknown-subset]
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2017-2022 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This Font Software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ? (com.google.fonts/check/metadata/match_fullname_postscript)
  • 🔥 FAIL METADATA.pb font full_name = "Noto Serif HK" does not match post_script_name = "NotoSerifHK-ExtraLight" [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
  • 🔥 FAIL Font names are incorrect:
nameID current expected
Family Name Noto Serif HK Noto Serif HK ExtraLight
Subfamily Name Regular Regular
Full Name Noto Serif HK Noto Serif HK ExtraLight
Poscript Name NotoSerifHK-ExtraLight NotoSerifHK-ExtraLight
Typographic Family Name N/A Noto Serif HK
Typographic Subfamily Name ExtraLight ExtraLight
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Delete additional instances
Name current expected
Thin wght=100.0 N/A
ExtraBlack wght=1000.0 N/A
ExtraLight wght=200.0 wght=200.0
Light wght=300.0 wght=300.0
Regular wght=400.0 wght=400.0
Medium wght=500.0 wght=500.0
SemiBold wght=600.0 wght=600.0
Bold wght=700.0 wght=700.0
ExtraBold wght=800.0 wght=800.0
Black wght=900.0 wght=900.0
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

    • acutecomb

    • gravecomb

    • uni0307

    • And uni030C [code: unattached-dotted-circle-marks]

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'ExtraLight' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:269]
🔥 FAIL: STAT table has Axis Value tables? (com.adobe.fonts/check/stat_has_axis_value_tables)
  • 🔥 FAIL STAT table is missing Axis Value for 'wght' value '100.0' [code: missing-axis-value-table]
  • 🔥 FAIL STAT table is missing Axis Value for 'wght' value '1000.0' [code: missing-axis-value-table]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • glyph00470

    • glyph00472

    • glyph00473

    • glyph00477

    • glyph00603

    • glyph01006

    • glyph01112

    • glyph01134

    • glyph01148

    • glyph01149

    • And 102 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
/Users/rosalie/Desktop/NotoSansQA/fonts/ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size 16.1Mb
Hinted Size 16.1Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.001-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.001-H1;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp

    • vhea

    • And vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO /Users/rosalie/Desktop/NotoSansQA/fonts/ofl/notoserifhk [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
1 15 9 55 8 139 0
0% 7% 4% 24% 4% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

follow up in #5535

@RosaWagner RosaWagner closed this Mar 15, 2023
@RosaWagner RosaWagner deleted the NotoSerifHK-hotfix1 branch June 16, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants