Noto Serif HK: Version 2.001-H2 added

[simoncozens]

Metadata change here is different to the Sans versions; not sure why...

[gf-bot]

Fontbakery report

Fontbakery version: 0.8.11a3

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  ('wght', 1) [code: summary]

[31] NotoSerifHK[wght].ttf

💔 ERROR: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

• 💔 ERROR Failed with KeyError: 'cjy_Hant'
• ℹ INFO No sample_glyphs on METADATA.pb [code: no-samples]

🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

• 🔥 FAIL Missing required codepoints:

  • 0x0308 (COMBINING DIAERESIS)

  • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

  • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

  • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

  • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

  • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

  • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

  • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

  • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

  • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

  • And 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)

• 🔥 FAIL Please remove the unrecognized subset 'chinese-hongkong' from the METADATA.pb file. [code: unknown-subset]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

• 🔥 FAIL First line in license file is:

"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)

• 🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

• 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
  "Copyright 2020 The Familyname Project Authors (git url)"
  But instead we have got:
  "(c) 2017-2022 adobe (http://www.adobe.com/), with reserved font name 'source'." [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

• 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
  But instead we have got:
  "(c) 2017-2022 Adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)

• 🔥 FAIL Copyright field for this font on METADATA.pb ("(c) 2017-2022 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'.") differs from a copyright notice entry on the name table: "(c) 2017-2022 Adobe (http://www.adobe.com/)." [code: mismatch]

🔥 FAIL: Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/cjk_vertical_metrics_regressions)

• 🔥 FAIL hhea ascent is 1160 when it should be 1000 [code: cjk-metric-regression]
• 🔥 FAIL hhea descent is -288 when it should be -200 [code: cjk-metric-regression]

🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• 🔥 FAIL The avatar filename provided seems to be incorrect: (https://raw.githubusercontent.com/google/fonts/master/catalog/designers/google/) [code: bad-avatar-filename]

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

  • acutecomb

  • gravecomb

  • uni0307

  • And uni030C [code: unattached-dotted-circle-marks]

⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)

• ⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)

• ⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)

• ⚠ WARN METADATA.pb: copyright field ("(c) 2017-2022 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • f + f

  • f + i

  • i + f

  • f + l

  • l + f

  • And i + l [code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)

• ⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
  FONT_FAMILY_NAME = 'Noto Serif HK ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • glyph00470

  • glyph00472

  • glyph00473

  • glyph00477

  • glyph00603

  • glyph01006

  • glyph01112

  • glyph01134

  • glyph01668

  • glyph01670

  • And 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)

• ⚠ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature]
• ⚠ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]

⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)

• ⚠ WARN Interpolation issues were found in the font: - Contour 2 start point differs in glyph 'uni2299' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1d5946f5e0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1d59f23a60> [code: interpolation-issues]

⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)

• ⚠ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]

⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)

• ⚠ WARN The following mark characters could be in the GDEF mark glyph class:
  uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size	16.1Mb
Hinted Size	16.1Mb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

• ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.001-H2;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 2.001-H2;hotconv 1.1.0;makeotfexe 2.6.0"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • loca

  • prep

  • BASE

  • GPOS

  • GSUB

  • gasp

  • vhea

  • And vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/notoserifhk [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
1	10	13	54	8	147	0
0%	4%	6%	23%	3%	63%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[RosaWagner]

@simoncozens Noto Sans HK supports languages: "za_Hant" # Zhuang, Traditional Han, is this something we want to add it here?

[RosaWagner]

Looks like linespacing has increased

Enregistrement.de.l.ecran.2022-11-16.a.12.33.04.mov

[simoncozens]

Linespacing issue is deliberate. Noto CJK statics from upstream have ascent=1160,descent=-288 but the upstream VFs have ascent=1000,descent=-200. As we are now updating Noto Sans CJK from static to VF, we are hotfixing the VFs to have compatible vertical metrics with the static versions.

But Noto Serif CJK was originally added as a VF before we knew about the static/VF metrics difference, so it was onboarded with the tighter VF metrics. I think it's better to hotfix the metrics here as well, so that Serif and Sans have compatible metrics.

[simoncozens]

Please hold this one for now. There was another (slight) vertical metrics problem as I made the metrics compatible with the old sans, not from the old serif.

[RosaWagner]

Shouldn't it be similar to new Sans, so the entire CJK family has the same v-metrics?

[simoncozens]

I don't think so. Upstream deliberately has slightly different metrics for Sans and Serif, and they always have had it like this. I don't know why (@punchcutter?) but my plan was to try to avoid regressions between Serif 1.0 and 2.0 by keeping the metrics the same.

[punchcutter]

At the time I'm not sure it was considered. Same for a lot of other things like variable fonts which didn't exist in the current state when this project was started. The CJK have always been a little odd and don't conform to all the new Noto rules that have evolved over the years.