Add BHive Comparison script #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a script for comparing BHive format CSVs (the first column being the hex bb and the second column being the throughput value). The script just outputs the average deviation between the two values.
|
Opening this as a draft for now as it needs some additional work and isn't ready for review. Need something to remind me that it exists though when I go back to find it. |
ondrasej
requested changes
Apr 21, 2024
There was a problem hiding this comment.
We should have tests for the tool - and ideally also split this into cc_library + cc_binary with most code in the library, and unit test the library.
ondrasej
requested changes
Sep 2, 2024
Comment on lines
+59
to
+65
| std::string_view ThroughputValue1String = | ||
| std::string_view(File1Line).substr(Line1CommaIndex + 1, | ||
| File1Line.size()); | ||
|
|
||
| std::string_view ThroughputValue2String = | ||
| std::string_view(File2Line).substr(Line2CommaIndex + 1, | ||
| File2Line.size()); |
There was a problem hiding this comment.
We should either check that the blocks are the same or load both files to memory, and join them by the block hex before comparing. Otherwise, this might produce misleading results :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a script for comparing BHive format CSVs (the first column being the hex bb and the second column being the throughput value). The script just outputs the average deviation between the two values.