Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BHive Comparison script #97

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gematria/datasets/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -188,3 +188,11 @@ cc_library(
],
deps = ["@com_google_absl//absl/types:span"],
)

cc_binary(
name = "compare_bhive_csv",
srcs = ["compare_bhive_csv.cc"],
deps = [
"@llvm-project//llvm:Support",
],
)
87 changes: 87 additions & 0 deletions gematria/datasets/compare_bhive_csv.cc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have tests for the tool - and ideally also split this into cc_library + cc_binary with most code in the library, and unit test the library.

Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
// Copyright 2024 Google Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#include <cmath>
#include <fstream>
#include <string>
#include <string_view>

#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/Errc.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/raw_ostream.h"

using namespace llvm;

static cl::opt<std::string> InputFilePath1(
"input-file-a", cl::desc("Path to the first input CSV."), cl::init(""));

static cl::opt<std::string> InputFilePath2(
"input-file-b", cl::desc("Path to the second input CSV."), cl::init(""));

int main(int Argc, char **Argv) {
cl::ParseCommandLineOptions(Argc, Argv, "compare_bhive_csv");

ExitOnError ExitOnErr("compare_bhive_csv error: ");

if (InputFilePath1.empty() || InputFilePath2.empty())
ExitOnErr(llvm::make_error<StringError>(
errc::invalid_argument, "Input file paths must not be empty"));

std::ifstream InputFile1 = std::ifstream(InputFilePath1);
std::ifstream InputFile2 = std::ifstream(InputFilePath2);

double DeviationSum = 0.0;
int FileCount = 0;

for (std::string File1Line, File2Line; std::getline(InputFile1, File1Line) &&
std::getline(InputFile2, File2Line);) {
size_t Line1CommaIndex = File1Line.find(',');
size_t Line2CommaIndex = File2Line.find(',');

if (Line1CommaIndex == std::string::npos ||
Line2CommaIndex == std::string::npos)
ExitOnErr(llvm::make_error<StringError>(errc::invalid_argument,
"No comma found on input line"));

std::string_view ThroughputValue1String =
std::string_view(File1Line).substr(Line1CommaIndex + 1,
File1Line.size());

std::string_view ThroughputValue2String =
std::string_view(File2Line).substr(Line2CommaIndex + 1,
File2Line.size());
Comment on lines +59 to +65
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either check that the blocks are the same or load both files to memory, and join them by the block hex before comparing. Otherwise, this might produce misleading results :)


int ThroughputValue1 = 0;
int ThroughputValue2 = 0;

if (!to_integer(StringRef(ThroughputValue1String), ThroughputValue1) ||
!to_integer(StringRef(ThroughputValue2String), ThroughputValue2)) {
ExitOnErr(llvm::make_error<StringError>(
errc::invalid_argument, "Failed to parse integer values"));
}

double Deviation =
std::abs((double)ThroughputValue1 - (double)ThroughputValue2) /
(double)ThroughputValue1;
DeviationSum += Deviation;

++FileCount;
}

outs() << "Average deviation: " << DeviationSum / (double)FileCount << "\n";

return 0;
}
Loading