-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BHive Comparison script #97
Open
boomanaiden154
wants to merge
3
commits into
main
Choose a base branch
from
users/boomanaiden154/bhive-comparison-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
// Copyright 2024 Google Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <cmath> | ||
#include <fstream> | ||
#include <string> | ||
#include <string_view> | ||
|
||
#include "llvm/ADT/StringExtras.h" | ||
#include "llvm/Support/CommandLine.h" | ||
#include "llvm/Support/Errc.h" | ||
#include "llvm/Support/Error.h" | ||
#include "llvm/Support/raw_ostream.h" | ||
|
||
using namespace llvm; | ||
|
||
static cl::opt<std::string> InputFilePath1( | ||
"input-file-a", cl::desc("Path to the first input CSV."), cl::init("")); | ||
|
||
static cl::opt<std::string> InputFilePath2( | ||
"input-file-b", cl::desc("Path to the second input CSV."), cl::init("")); | ||
|
||
int main(int Argc, char **Argv) { | ||
cl::ParseCommandLineOptions(Argc, Argv, "compare_bhive_csv"); | ||
|
||
ExitOnError ExitOnErr("compare_bhive_csv error: "); | ||
|
||
if (InputFilePath1.empty() || InputFilePath2.empty()) | ||
ExitOnErr(llvm::make_error<StringError>( | ||
errc::invalid_argument, "Input file paths must not be empty")); | ||
|
||
std::ifstream InputFile1 = std::ifstream(InputFilePath1); | ||
std::ifstream InputFile2 = std::ifstream(InputFilePath2); | ||
|
||
double DeviationSum = 0.0; | ||
int FileCount = 0; | ||
|
||
for (std::string File1Line, File2Line; std::getline(InputFile1, File1Line) && | ||
std::getline(InputFile2, File2Line);) { | ||
size_t Line1CommaIndex = File1Line.find(','); | ||
size_t Line2CommaIndex = File2Line.find(','); | ||
|
||
if (Line1CommaIndex == std::string::npos || | ||
Line2CommaIndex == std::string::npos) | ||
ExitOnErr(llvm::make_error<StringError>(errc::invalid_argument, | ||
"No comma found on input line")); | ||
|
||
std::string_view ThroughputValue1String = | ||
std::string_view(File1Line).substr(Line1CommaIndex + 1, | ||
File1Line.size()); | ||
|
||
std::string_view ThroughputValue2String = | ||
std::string_view(File2Line).substr(Line2CommaIndex + 1, | ||
File2Line.size()); | ||
Comment on lines
+59
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should either check that the blocks are the same or load both files to memory, and join them by the block hex before comparing. Otherwise, this might produce misleading results :) |
||
|
||
int ThroughputValue1 = 0; | ||
int ThroughputValue2 = 0; | ||
|
||
if (!to_integer(StringRef(ThroughputValue1String), ThroughputValue1) || | ||
!to_integer(StringRef(ThroughputValue2String), ThroughputValue2)) { | ||
ExitOnErr(llvm::make_error<StringError>( | ||
errc::invalid_argument, "Failed to parse integer values")); | ||
} | ||
|
||
double Deviation = | ||
std::abs((double)ThroughputValue1 - (double)ThroughputValue2) / | ||
(double)ThroughputValue1; | ||
DeviationSum += Deviation; | ||
|
||
++FileCount; | ||
} | ||
|
||
outs() << "Average deviation: " << DeviationSum / (double)FileCount << "\n"; | ||
|
||
return 0; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have tests for the tool - and ideally also split this into cc_library + cc_binary with most code in the library, and unit test the library.