Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make log severity type safe #1025

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: make log severity type safe #1025

merged 1 commit into from
Jan 3, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 3, 2024

Fixes #590

@sergiud sergiud added the bug label Jan 3, 2024
@sergiud sergiud added this to the 0.7 milestone Jan 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (51e7a43) 58.75% compared to head (2f5e950) 59.01%.

Files Patch % Lines
src/logging.cc 53.33% 7 Missing ⚠️
src/signalhandler.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   58.75%   59.01%   +0.26%     
==========================================
  Files          18       18              
  Lines        2560     2550      -10     
  Branches      918      912       -6     
==========================================
+ Hits         1504     1505       +1     
+ Misses        707      701       -6     
+ Partials      349      344       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud merged commit 54b2c17 into master Jan 3, 2024
268 checks passed
@sergiud sergiud deleted the log-severity branch January 3, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can SetLogger set severity to -1?
2 participants