Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog 0.7.0 #163094

Closed
wants to merge 13 commits into from
Closed

glog 0.7.0 #163094

wants to merge 13 commits into from

Conversation

Porkepix
Copy link
Contributor

Created by brew bump

Created with brew bump-formula-pr.

release notes 
In this release, glog underwent a major overhaul to take advantage of C++14 language and library features. Among the many changes, the public API has also been extended to use the more up-to-date standard library types (notably `chrono`).

Highlights


    

  • C++14 is now the primary language standard
    • 

  • Emscripten support
    • 

  • Many fixes and enhancements
    • 



Compatibility


glog aims to maintain source compatibility with the previous release. We did our best to ensure such compatibility in this version as well. However, downstream clients must recompile against the new glog version due to ABI incompatible changes.


Deprecations


A number of functions, methods, and types have been deprecated in favor of more uniform interface.




[!WARNING]

Deprecated methods will be removed in glog 0.8.0. Please make sure to update your code.




    

  • google::LogMessage::getMessageTime has been superseded by google::LogMessage::time.
    • 

  • google::LogMessageTime::timestamp has been superseded by  google::LogMessageTime::when.
    • 

  • google::LogMessageTime::gmtoff has been superseded by google::LogMessageTime::gmtoffset.
    • 

  • google::EnableLogCleaner(unsigned) has been superseded by google::EnableLogCleaner(std::chrono::minutes).
    • 

  • google::LogSink::send accepting std::tm (deprecated since glog 0.6.0) has been superseded by google::LogSink::send to accept google::LogMessageTime instead.
    • 

  • google::LogMessageInfo and the custom prefix callback accepting this type have been superseded by google::LogMessage. To customize the log line prefix use the google::InstallPrefixFormatter function instead of the google::InitGoogleLogging overload.
    • 



Further changes


    

  • google::LogSeverity has been converted to an unscoped enum. This can result in compilation issues if implicit conversion between an int and google::LogSeverity was erroneously assumed.
    • 

  • By default, CMake no longer generates the undocumented and untested pkg-config files. The support is now opt in which requires the CMake option WITH_PKGCONFIG to be explicitly set to ON.
    • 



What's Changed



New Contributors



Full Changelog: google/glog@v0.6.0...v0.7.0

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Feb 17, 2024
@chenrui333 chenrui333 force-pushed the bump-glog-0.7.0 branch 2 times, most recently from 0f9f71c to 1857446 Compare February 18, 2024 01:20
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Feb 19, 2024
@chenrui333
Copy link
Member 

  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken.cpp:17:
  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken.h:365:
  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken-inl.h:23:
  /opt/homebrew/include/glog/logging.h:60:4: error: <glog/logging.h> was not included correctly. See the documention for how to consume the library.
  #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
     ^
  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken.cpp:17:
  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken.h:365:
  In file included from /tmp/folly-20240217-10401-zl3qgf/folly-2024.01.22.00/folly/CancellationToken-inl.h:23:
  In file included from /opt/homebrew/include/glog/logging.h:63:
  /opt/homebrew/include/glog/flags.h:45:4: error: <glog/flags.h> was not included correctly. See the documention for how to consume the library.
  #  error <glog/flags.h> was not included correctly. See the documention for how to consume the library.
     ^
  /opt/homebrew/include/glog/flags.h:105:1: error: unknown type name 'GLOG_EXPORT'
  DECLARE_int32(logemaillevel);
  ^
  /opt/homebrew/include/glog/flags.h:88:31: note: expanded from macro 'DECLARE_int32'
  #  define DECLARE_int32(name) DECLARE_VARIABLE(google::int32, I, name, int32)
                                ^
  /opt/homebrew/include/glog/flags.h:80:14: note: expanded from macro 'DECLARE_VARIABLE'
        extern GLOG_EXPORT type FLAGS_##name;           \
               ^
  /opt/homebrew/include/glog/flags.h:105:1: error: cannot define or redeclare 'int32' here because namespace 'fLI' does not enclose namespace 'google'
  DECLARE_int32(logemaillevel);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /opt/homebrew/include/glog/flags.h:88:56: note: expanded from macro 'DECLARE_int32'
  #  define DECLARE_int32(name) DECLARE_VARIABLE(google::int32, I, name, int32)
                                                 ~~~~~~~~^
  /opt/homebrew/include/glog/flags.h:80:26: note: expanded from macro 'DECLARE_VARIABLE'
        extern GLOG_EXPORT type FLAGS_##name;           \
                           ^~~~
  /opt/homebrew/include/glog/flags.h:105:1: error: expected ';' after top level declarator
  /opt/homebrew/include/glog/flags.h:88:31: note: expanded from macro 'DECLARE_int32'
  #  define DECLARE_int32(name) DECLARE_VARIABLE(google::int32, I, name, int32)
                                ^
  /opt/homebrew/include/glog/flags.h:80:31: note: expanded from macro 'DECLARE_VARIABLE'
        extern GLOG_EXPORT type FLAGS_##name;           \
                                ^
  <scratch space>:349:1: note: expanded from here
  FLAGS_logemaillevel
  ^

@chenrui333 chenrui333 added the build failure CI fails while building the software label Feb 19, 2024
@cho-m cho-m force-pushed the bump-glog-0.7.0 branch 2 times, most recently from 6f02834 to a7f88eb Compare March 21, 2024 17:54
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Apr 2, 2024
This was referenced Apr 4, 2024
Closed
Open
@c8ef c8ef mentioned this pull request Apr 15, 2024
Closed
Porkepix and others added 13 commits May 4, 2024 21:54
@Porkepix @iMichka
glog 0.7.0
dc3dff2 
glog: update test

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
ceres-solver: revision bump (glog 0.7.0)
eeed8d3 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
edencommon: revision bump (glog 0.7.0)
94701fd 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
fb303: revision bump (glog 0.7.0)
a5a8ce5 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
fizz: revision bump (glog 0.7.0)
0979b2c 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
libgrape-lite: revision bump (glog 0.7.0)
b7de334 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
proxygen: revision bump (glog 0.7.0)
2be17b9 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
treefrog: revision bump (glog 0.7.0)
f7d2836 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
wangle: revision bump (glog 0.7.0)
7caf1e7 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
watchman: revision bump (glog 0.7.0)
43336d4 
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m @iMichka
s2geometry: revision bump (glog 0.7.0)
54c4d14
@chenrui333 @iMichka
folly: revision bump (glog 0.7.0)
7c66d12 
Add patch to work with `glog` 0.7

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@chenrui333 @iMichka
opencv: revision bump (glog 0.7.0)
f908ebf 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@c8ef c8ef mentioned this pull request May 11, 2024
Closed
@p-linnane p-linnane closed this Jun 7, 2024
@chenrui333 chenrui333 mentioned this pull request Jun 14, 2024
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-requeued PR has been re-added to the queue in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Porkepix @chenrui333 @p-linnane @cho-m