cmake: replace check_library_exists by check_cxx_symbol_exists
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 64.14% 64.22% +0.07%
==========================================
Files 17 17
Lines 3327 3326 -1
Branches 1125 1125
==========================================
+ Hits 2134 2136 +2
+ Misses 766 765 -1
+ Partials 427 425 -2 ☔ View full report in Codecov by Sentry. |
As per https://gitlab.kitware.com/cmake/cmake/-/issues/18121, check_library_exists cannot not determine the availability of a symbol in a static library. Switch to check_cxx_symbol_exists to avoid incorrectly detecting the presence of dbghelp.
sergiud
force-pushed
the
cmake-dbghelp
branch
from
d50d61f
to
c217f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://gitlab.kitware.com/cmake/cmake/-/issues/18121, check_library_exists cannot not determine the availability of a symbol in a static library. Switch to check_cxx_symbol_exists to avoid incorrectly detecting the presence of dbghelp.
Fixes #982