Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing debug-logging macros #986

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

4c3y
Copy link
Contributor

@4c3y 4c3y commented Dec 12, 2023

Closes #861

Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6607b36) 64.25% compared to head (b40459f) 64.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   64.25%   64.25%           
=======================================
  Files          17       17           
  Lines        3321     3321           
  Branches     1124     1124           
=======================================
  Hits         2134     2134           
  Misses        760      760           
  Partials      427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud
Copy link
Collaborator

sergiud commented Dec 20, 2023

Thanks for the PR.

Could you please rebase and update the README.rst here by listing the new macros?

@4c3y
Copy link
Contributor Author

4c3y commented Dec 21, 2023

Done.

@sergiud sergiud added this to the 0.7 milestone Dec 21, 2023
@sergiud
Copy link
Collaborator

sergiud commented Dec 21, 2023

Thank you!

@sergiud sergiud merged commit 716be9e into google:master Dec 21, 2023
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLOG_FIRST_N() and DLOG_EVERY_T() macro missing
3 participants