Skip to content

Commit

Permalink
Don't warn about fallback unless we need to (#996)
Browse files Browse the repository at this point in the history
We were hitting this warning when listing an empty repository, which
doesn't make sense.
  • Loading branch information
jonjohnsonjr committed Apr 28, 2021
1 parent 83f4080 commit dff71aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/v1/google/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ func (l *lister) list(repo name.Repository) (*Tags, error) {
}

// This isn't GCR, just append the tags and keep paginating.
logs.Warn.Printf("saw non-google tag listing response, falling back to pagination")
tags.Tags = append(tags.Tags, parsed.Tags...)

uri, err = getNextPageURL(resp)
Expand All @@ -144,6 +143,7 @@ func (l *lister) list(repo name.Repository) (*Tags, error) {
if uri == nil {
break
}
logs.Warn.Printf("saw non-google tag listing response, falling back to pagination")
}

return &tags, nil
Expand Down

0 comments on commit dff71aa

Please sign in to comment.