Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about fallback unless we need to #996

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

We were hitting this warning when listing an empty repository, which
doesn't make sense.

We were hitting this warning when listing an empty repository, which
doesn't make sense.
@codecov-commenter
Copy link

Codecov Report

Merging #996 (ac93bb2) into main (83f4080) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   75.19%   75.17%   -0.02%     
==========================================
  Files         107      107              
  Lines        5064     5064              
==========================================
- Hits         3808     3807       -1     
- Misses        711      712       +1     
  Partials      545      545              
Impacted Files Coverage Δ
pkg/v1/google/list.go 70.49% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f4080...ac93bb2. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit dff71aa into google:main Apr 28, 2021
@jonjohnsonjr jonjohnsonjr deleted the better-warning branch April 28, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants