feat(daemon): generate config file from Docker Engine API #1130
Conversation
knqyf263
changed the title
| return nil, err | ||
| } | ||
| return i.tarballImage.ConfigFile() | ||
| return i.configFile.DeepCopy(), nil |
There was a problem hiding this comment.
Interesting... so this lets you get the semantic image config cheaply, but if you want to actual config file docker would generate, we have to actually save the image and have docker do this serialization?
Somewhat confusing but it's nice that it's possible. What's the use case you have where you need quick access to the config file?
There was a problem hiding this comment.
but if you want to actual config file docker would generate, we have to actually save the image and have docker do this serialization?
As far as I know, it is the case. I didn't find Docker Engine API returning the actual config.
What's the use case you have where you need quick access to the config file?
Strictly speaking, we just need to get diff_id quickly so that we can check if the layer is already cached or not. Image ID doesn't meet our requirements. Let's say Image B is based on Image A like the following:
- Image B
- Layer 2
- Layer 1
- Image A
- Layer 1
If we scan Image B, our cache should have image_id of Image B and diff_ids of Layer 1 and 2. Then, when we scan Image A, the image_id of Image A will be missed, while the diff_id of Layer 1 exists in the cache. In this case, we don't have to save Image A as we're actually interested in the layer content only.
Currently, we cannot skip saving Image A even though Layer 1 exists in our cache.
There was a problem hiding this comment.
Can you add a test that compares the result of ConfigFile() with calling RawConfigFile() and parsing it?
I'm ok if they're not identical, but I'd like to see which fields are missing or different.
There was a problem hiding this comment.
If I understand correctly, ConfigFile() and RawConfigFile() are already compared here.
go-containerregistry/pkg/v1/validate/image.go
Lines 90 to 92 in ca48523
|
This Pull Request is stale because it has been open for 90 days with |
|
@knqyf263 still interested in this? |
|
Yes, but I don't have time recently. Hopefully, I will find some time next week. |
Codecov Report
@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
- Coverage 74.07% 73.97% -0.10%
==========================================
Files 112 112
Lines 8385 8501 +116
==========================================
+ Hits 6211 6289 +78
- Misses 1570 1598 +28
- Partials 604 614 +10
Continue to review full report at Codecov.
|
|
This Pull Request is stale because it has been open for 90 days with |
Description
#1121 allows
daemon.Imageto get a config name without exporting a tar file. This PR also generates a config file fromdocker inspectanddocker historywithout exporting. Note thatRawConfigFile()cannot be emulated by Docker Engine API as far as I know.I referred to this implementation.
go-containerregistry/pkg/v1/mutate/image.go
Line 52 in 0e8b581
In addition, I changed some value receivers to pointer receivers since we should not mix receiver types.
https://github.com/golang/go/wiki/CodeReviewComments#receiver-type