-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daemon): generate config file from Docker Engine API #1130
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... so this lets you get the semantic image config cheaply, but if you want to actual config file docker would generate, we have to actually save the image and have docker do this serialization?
Somewhat confusing but it's nice that it's possible. What's the use case you have where you need quick access to the config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, it is the case. I didn't find Docker Engine API returning the actual config.
Strictly speaking, we just need to get diff_id quickly so that we can check if the layer is already cached or not. Image ID doesn't meet our requirements. Let's say Image B is based on Image A like the following:
If we scan Image B, our cache should have image_id of Image B and diff_ids of Layer 1 and 2. Then, when we scan Image A, the image_id of Image A will be missed, while the diff_id of Layer 1 exists in the cache. In this case, we don't have to save Image A as we're actually interested in the layer content only.
Currently, we cannot skip saving Image A even though Layer 1 exists in our cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that compares the result of
ConfigFile()
with callingRawConfigFile()
and parsing it?I'm ok if they're not identical, but I'd like to see which fields are missing or different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly,
ConfigFile()
andRawConfigFile()
are already compared here.go-containerregistry/pkg/v1/validate/image.go
Lines 90 to 92 in ca48523