-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support artifactType, for images whose config.mediaType is not a config #1541
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 73.31% 73.09% -0.22%
==========================================
Files 117 117
Lines 9015 9065 +50
==========================================
+ Hits 6609 6626 +17
- Misses 1746 1776 +30
- Partials 660 663 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. There are probably some things we missed, but let's let this bake for a bit before we cut a release.
If an index contains an image whose config.mediaType is not the normal config type (i.e., it's an artifact, packaged as an image for registry compatibility), the index's descriptor for the image will include
artifactType
.This is work toward supporting the OCI 1.1 referrers fallback tag scheme, where referrers are managed by the client and pushed as indexes to the registry, tagged with
:sha256-abcdef...
.cc @jdolitsky