Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OCI 1.1+ referrers via fallback tag #1543

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

jdolitsky
Copy link
Contributor

Builds on top of #1541

Crane subcommands "attach" and "refs" dropped in this PR, but can be found here: https://github.com/google/go-containerregistry/compare/main...jdolitsky:attach-pt-3?expand=1

cc @imjasonh

pkg/v1/remote/referrers.go Outdated Show resolved Hide resolved
@jdolitsky jdolitsky marked this pull request as ready for review January 27, 2023 22:18
Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

pkg/v1/remote/descriptor.go Outdated Show resolved Hide resolved
pkg/v1/remote/descriptor.go Outdated Show resolved Hide resolved
pkg/v1/remote/descriptor.go Outdated Show resolved Hide resolved
pkg/v1/remote/descriptor.go Outdated Show resolved Hide resolved
pkg/v1/remote/descriptor.go Show resolved Hide resolved
pkg/v1/remote/image.go Outdated Show resolved Hide resolved
pkg/v1/remote/referrers_test.go Outdated Show resolved Hide resolved
pkg/v1/types/types.go Outdated Show resolved Hide resolved
pkg/name/digest.go Outdated Show resolved Hide resolved
pkg/v1/mutate/mutate.go Show resolved Hide resolved
pkg/v1/remote/write.go Show resolved Hide resolved
pkg/v1/types/types.go Outdated Show resolved Hide resolved
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@codecov-commenter
Copy link

Codecov Report

Merging #1543 (1e16e45) into main (da1008f) will decrease coverage by 0.31%.
The diff coverage is 52.70%.

@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
- Coverage   73.07%   72.77%   -0.31%     
==========================================
  Files         117      118       +1     
  Lines        9082     9230     +148     
==========================================
+ Hits         6637     6717      +80     
- Misses       1780     1829      +49     
- Partials      665      684      +19     
Impacted Files Coverage Δ
pkg/v1/manifest.go 100.00% <ø> (ø)
pkg/v1/remote/delete.go 58.62% <ø> (ø)
pkg/v1/mutate/mutate.go 69.01% <10.52%> (-3.80%) ⬇️
pkg/v1/remote/referrers.go 40.00% <40.00%> (ø)
pkg/v1/remote/write.go 63.12% <55.95%> (-0.99%) ⬇️
pkg/v1/remote/descriptor.go 73.84% <61.53%> (-0.44%) ⬇️
pkg/v1/mutate/image.go 69.56% <100.00%> (+0.33%) ⬆️
pkg/v1/mutate/index.go 79.33% <100.00%> (+0.34%) ⬆️
pkg/v1/remote/options.go 77.77% <100.00%> (+1.41%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjohnsonjr anything else?

@imjasonh imjasonh merged commit 061ee6b into google:main Jan 31, 2023
@jdolitsky jdolitsky deleted the oci-1-1 branch January 31, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants