Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crane edit to generate non-image artifacts #1545

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Jan 26, 2023

Instead of using mutate, just do this ourselves to allow for arbitrary config file contents rather than mutating the OCI config struct.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super convinced we need to do more work to enable crane to produce invalid configs. Can this just live in a fork and not be supported behavior in crane?

@codecov-commenter
Copy link

Codecov Report

Merging #1545 (8b2fbca) into main (11843ba) will decrease coverage by 0.02%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
- Coverage   73.31%   73.29%   -0.02%     
==========================================
  Files         117      117              
  Lines        9015     9032      +17     
==========================================
+ Hits         6609     6620      +11     
- Misses       1746     1750       +4     
- Partials      660      662       +2     
Impacted Files Coverage Δ
internal/cmd/edit.go 53.48% <54.54%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Instead of using mutate, just do this ourselves to allow for arbitrary
config file contents rather than mutating the OCI config struct.
@jonjohnsonjr jonjohnsonjr changed the title Allow crane edit to produce invalid diffids Allow crane edit to generate non-image artifacts Jan 27, 2023
@jonjohnsonjr
Copy link
Collaborator Author

I have re-framed the change in terms of more generic usefulness.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this I can get behind! 😍

@imjasonh imjasonh merged commit 9306eba into google:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants