Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authn: Add NewConfigKeychain to load a config from explicit path #1603

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

imjasonh
Copy link
Collaborator

Fixes #1595

cc @hasheddan

pkg/authn/keychain.go Outdated Show resolved Hide resolved
@jonjohnsonjr
Copy link
Collaborator

Want to rebase this given the refresher stuff?

@imjasonh imjasonh enabled auto-merge (squash) April 18, 2023 16:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1603 (e72603c) into main (9aa45a1) will decrease coverage by 0.01%.
The diff coverage is 90.47%.

❗ Current head e72603c differs from pull request most recent head 677d403. Consider uploading reports for the commit 677d403 to get more accurate results

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
- Coverage   72.08%   72.08%   -0.01%     
==========================================
  Files         120      120              
  Lines        9782     9814      +32     
==========================================
+ Hits         7051     7074      +23     
- Misses       2011     2017       +6     
- Partials      720      723       +3     
Impacted Files Coverage Δ
pkg/authn/keychain.go 89.05% <87.23%> (-5.45%) ⬇️
pkg/v1/google/keychain.go 87.87% <100.00%> (+0.37%) ⬆️
pkg/v1/google/list.go 71.27% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for filepath-based authn.Keychain
3 participants